linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* vmstat: Update comment in stat_threshold
@ 2011-03-23 20:46 Christoph Lameter
  0 siblings, 0 replies; only message in thread
From: Christoph Lameter @ 2011-03-23 20:46 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm

This has been in my tree for awhile. I thought it would be merged
at some point into another patch but that did not happen.

It was first posted in a discussion of the vmstat changes for per cpu
atomics: http://www.gossamer-threads.com/lists/linux/kernel/1317000#1317000

Signed-off-by: Christoph Lameter <cl@linux.com>


---
 mm/vmstat.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Index: linux-2.6/mm/vmstat.c
===================================================================
--- linux-2.6.orig/mm/vmstat.c	2011-03-15 11:16:48.000000000 -0500
+++ linux-2.6/mm/vmstat.c	2011-03-17 09:25:26.000000000 -0500
@@ -321,9 +321,12 @@ static inline void mod_state(struct zone
 		/*
 		 * The fetching of the stat_threshold is racy. We may apply
 		 * a counter threshold to the wrong the cpu if we get
-		 * rescheduled while executing here. However, the following
-		 * will apply the threshold again and therefore bring the
-		 * counter under the threshold.
+		 * rescheduled while executing here. However, the next
+		 * counter update will apply the threshold again and
+		 * therefore bring the counter under the threshold again.
+		 *
+		 * Most of the time the thresholds are the same anyways
+		 * for all cpus in a zone.
 		 */
 		t = this_cpu_read(pcp->stat_threshold);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-03-23 20:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-23 20:46 vmstat: Update comment in stat_threshold Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox