From: Christoph Lameter <cl@linux.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org
Subject: vmstat: Update comment in stat_threshold
Date: Wed, 23 Mar 2011 15:46:20 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1103231542200.14654@router.home> (raw)
This has been in my tree for awhile. I thought it would be merged
at some point into another patch but that did not happen.
It was first posted in a discussion of the vmstat changes for per cpu
atomics: http://www.gossamer-threads.com/lists/linux/kernel/1317000#1317000
Signed-off-by: Christoph Lameter <cl@linux.com>
---
mm/vmstat.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: linux-2.6/mm/vmstat.c
===================================================================
--- linux-2.6.orig/mm/vmstat.c 2011-03-15 11:16:48.000000000 -0500
+++ linux-2.6/mm/vmstat.c 2011-03-17 09:25:26.000000000 -0500
@@ -321,9 +321,12 @@ static inline void mod_state(struct zone
/*
* The fetching of the stat_threshold is racy. We may apply
* a counter threshold to the wrong the cpu if we get
- * rescheduled while executing here. However, the following
- * will apply the threshold again and therefore bring the
- * counter under the threshold.
+ * rescheduled while executing here. However, the next
+ * counter update will apply the threshold again and
+ * therefore bring the counter under the threshold again.
+ *
+ * Most of the time the thresholds are the same anyways
+ * for all cpus in a zone.
*/
t = this_cpu_read(pcp->stat_threshold);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2011-03-23 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1103231542200.14654@router.home \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox