From: Christoph Lameter <cl@linux.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] slub,rcu: don't assume the size of struct rcu_head
Date: Tue, 8 Mar 2011 12:25:41 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1103081224550.25214@router.home> (raw)
In-Reply-To: <4D6CA852.3060303@cn.fujitsu.com>
On Tue, 1 Mar 2011, Lai Jiangshan wrote:
> - * RCU free overloads the RCU head over the LRU
> - */
> - struct rcu_head *head = (void *)&page->lru;
> + struct rcu_head *head;
> +
> + if (need_reserve_slab_rcu) {
> + int order = compound_order(page);
> + int offset = (PAGE_SIZE << order) - s->reserved;
> +
> + BUG_ON(s->reserved != sizeof(*head));
VM_BUG_ON is sufficient here I think.
Otherwise
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-03-08 18:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 8:03 Lai Jiangshan
2011-03-01 13:00 ` Pekka Enberg
2011-03-01 15:11 ` Christoph Lameter
2011-03-02 2:55 ` Lai Jiangshan
2011-03-02 4:31 ` Hugh Dickins
2011-03-02 12:32 ` Christoph Lameter
2011-03-06 19:39 ` Hugh Dickins
2011-03-08 2:17 ` Lai Jiangshan
2011-03-17 15:16 ` Christoph Lameter
2011-03-19 3:58 ` Hugh Dickins
2011-03-08 18:25 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1103081224550.25214@router.home \
--to=cl@linux.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox