From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>, Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org
Subject: Re: [patch] oom: prevent unnecessary oom kills or kernel panics
Date: Sun, 6 Mar 2011 14:06:26 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1103061404210.23737@chino.kir.corp.google.com> (raw)
In-Reply-To: <20110306201408.6CC6.A69D9226@jp.fujitsu.com>
On Sun, 6 Mar 2011, KOSAKI Motohiro wrote:
> > There is no deadlock being introduced by this patch; if you have an
> > example of one, then please show it. The problem is not just overkill but
> > rather panicking the machine when no other eligible processes exist. We
> > have seen this in production quite a few times and we'd like to see this
> > patch merged to avoid our machines panicking because the oom killer, by
> > your patch, isn't considering threads that are eligible in the exit path
> > once their parent has been killed and has exited itself yet memory freeing
> > isn't possible yet because the threads still pin the ->mm.
>
> No. While you don't understand current code, I'll not taking yours.
>
I take this as you declining to show your example of a deadlock introduced
by this patch as requested. There is no such deadlock. The patch is
reintroducing the behavior of the oom killer that existed for years before
you broke it and caused many of ours machines to panic as a result.
Thanks for your review.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-06 22:06 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 19:09 David Rientjes
2011-03-03 1:20 ` KOSAKI Motohiro
2011-03-03 19:53 ` David Rientjes
2011-03-06 11:14 ` KOSAKI Motohiro
2011-03-06 22:06 ` David Rientjes [this message]
2011-03-08 0:24 ` KOSAKI Motohiro
2011-03-08 2:01 ` KOSAKI Motohiro
2011-03-08 13:42 ` Oleg Nesterov
2011-03-08 23:57 ` David Rientjes
2011-03-09 10:36 ` KOSAKI Motohiro
2011-03-09 11:06 ` Oleg Nesterov
2011-03-09 20:32 ` David Rientjes
2011-03-10 12:05 ` Oleg Nesterov
2011-03-10 15:40 ` [PATCH 0/1] Was: " Oleg Nesterov
2011-03-10 15:41 ` [PATCH 1/1] oom_kill_task: mark every thread as TIF_MEMDIE Oleg Nesterov
2011-03-13 1:08 ` David Rientjes
2011-03-10 16:36 ` [PATCH 0/1] select_bad_process: improve the PF_EXITING check Oleg Nesterov
2011-03-10 16:37 ` [PATCH 1/1] " Oleg Nesterov
2011-03-10 16:40 ` [PATCH 0/1] " Oleg Nesterov
2011-03-10 17:18 ` [PATCH v2 " Oleg Nesterov
2011-03-10 17:19 ` [PATCH v2 1/1] " Oleg Nesterov
2011-03-13 1:06 ` [patch] oom: prevent unnecessary oom kills or kernel panics David Rientjes
2011-03-09 23:19 ` Andrew Morton
2011-03-11 19:45 ` David Rientjes
2011-03-12 12:34 ` Oleg Nesterov
2011-03-12 13:43 ` [PATCH 0/3] oom: TIF_MEMDIE/PF_EXITING fixes Oleg Nesterov
2011-03-12 13:44 ` [PATCH 1/3] oom: oom_kill_task: mark every thread as TIF_MEMDIE Oleg Nesterov
2011-03-13 1:14 ` David Rientjes
2011-03-12 13:44 ` [PATCH 2/3] oom: select_bad_process: improve the PF_EXITING check Oleg Nesterov
2011-03-12 13:44 ` [PATCH 3/3] oom: select_bad_process: use same_thread_group() Oleg Nesterov
2011-03-12 19:40 ` [PATCH 0/3] oom: TIF_MEMDIE/PF_EXITING fixes Hugh Dickins
2011-03-13 8:53 ` KOSAKI Motohiro
2011-03-13 21:27 ` Oleg Nesterov
2011-03-14 19:04 ` [PATCH 0/3 for 2.6.38] oom: fixes Oleg Nesterov
2011-03-14 19:04 ` [PATCH 1/3 for 2.6.38] oom: oom_kill_process: don't set TIF_MEMDIE if !p->mm Oleg Nesterov
2011-03-14 19:35 ` Linus Torvalds
2011-03-14 20:31 ` Oleg Nesterov
2011-03-14 20:32 ` David Rientjes
2011-03-15 19:12 ` Oleg Nesterov
2011-03-15 19:51 ` David Rientjes
2011-03-14 20:22 ` David Rientjes
2011-03-15 18:53 ` Oleg Nesterov
2011-03-15 19:54 ` David Rientjes
2011-03-15 21:16 ` Oleg Nesterov
2011-03-14 19:05 ` [PATCH 2/3 for 2.6.38] oom: select_bad_process: ignore TIF_MEMDIE zombies Oleg Nesterov
2011-03-14 20:50 ` David Rientjes
2011-03-14 19:05 ` [PATCH 3/3 for 2.6.38] oom: oom_kill_process: fix the child_points logic Oleg Nesterov
2011-03-14 20:41 ` David Rientjes
2011-03-15 19:21 ` Oleg Nesterov
2011-03-13 11:36 ` [PATCH 0/3] oom: TIF_MEMDIE/PF_EXITING fixes KOSAKI Motohiro
2011-03-13 1:11 ` [patch] oom: prevent unnecessary oom kills or kernel panics David Rientjes
2011-03-13 1:15 ` [patch -mm] oom: avoid deferring oom killer if exiting task is being traced David Rientjes
2011-03-14 17:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1103061404210.23737@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox