linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-mm@kvack.org
Subject: Re: [patch 1/3] oom: suppress nodes that are not allowed from meminfo on oom kill
Date: Wed, 19 Jan 2011 18:58:21 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1101191857550.32605@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101111712190.20611@chino.kir.corp.google.com>

On Tue, 11 Jan 2011, David Rientjes wrote:

> The oom killer is extremely verbose for machines with a large number of
> cpus and/or nodes.  This verbosity can often be harmful if it causes
> other important messages to be scrolled from the kernel log and incurs a
> signicant time delay, specifically for kernels with
> CONFIG_NODES_SHIFT > 8.
> 
> This patch causes only memory information to be displayed for nodes that
> are allowed by current's cpuset when dumping the VM state.  Information
> for all other nodes is irrelevant to the oom condition; we don't care if
> there's an abundance of memory elsewhere if we can't access it.
> 
> This only affects the behavior of dumping memory information when an oom
> is triggered.  Other dumps, such as for sysrq+m, still display the
> unfiltered form when using the existing show_mem() interface.
> 
> Additionally, the per-cpu pageset statistics are extremely verbose in oom
> killer output, so it is now suppressed.  This removes
> 
> 	nodes_weight(current->mems_allowed) * (1 + nr_cpus)
> 
> lines from the oom killer output.
> 
> Callers may use __show_mem(SHOW_MEM_FILTER_NODES) to filter disallowed
> nodes.

Are there any objections to merging this series in -mm?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2011-01-20  2:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12  1:13 David Rientjes
2011-01-12  1:13 ` [patch 2/3] oom: suppress show_mem() for many nodes in irq context on page alloc failure David Rientjes
2011-01-12  1:13 ` [patch 3/3] oom: suppress nodes that are not allowed from meminfo " David Rientjes
2011-01-20  2:58 ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1101191857550.32605@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox