From: Christoph Lameter <cl@linux.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mel@csn.ul.ie,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Rename struct task variables from p to tsk
Date: Wed, 12 Jan 2011 14:23:25 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1101121421490.9271@router.home> (raw)
In-Reply-To: <20110112201602.GA25957@mgebm.net>
On Wed, 12 Jan 2011, Eric B Munson wrote:
> On Wed, 12 Jan 2011, Christoph Lameter wrote:
> > Use t instead of p? Its a local variable after all.
>
> I don't find t any more informative than p. As a newcomer to most of this code
> informative variable names, even for local variables, is a huge help.
Local variables are short because they are defined close to the point of
use.
tsk is not that informative and the notion of a "task" can refer to
various. However, when I see
struct task_struct *t;
I know what it refers to.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-12 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 15:19 Eric B Munson
2011-01-12 18:05 ` Christoph Lameter
2011-01-12 20:16 ` Eric B Munson
2011-01-12 20:23 ` Christoph Lameter [this message]
2011-01-12 20:16 ` David Rientjes
2011-01-12 23:14 ` Minchan Kim
2011-01-13 3:23 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1101121421490.9271@router.home \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=emunson@mgebm.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox