From: David Rientjes <rientjes@google.com>
To: Shaohui Zheng <shaohui.zheng@intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
lethal@linux-sh.org, ak@linux.intel.com,
shaohui.zheng@linux.intel.com, Yinghai Lu <yinghai@kernel.org>,
Haicheng Li <haicheng.li@intel.com>
Subject: Re: [1/8,v3] NUMA Hotplug Emulator: add function to hide memory region via e820 table.
Date: Wed, 17 Nov 2010 00:16:34 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1011162354390.16875@chino.kir.corp.google.com> (raw)
In-Reply-To: <20101117021000.479272928@intel.com>
On Wed, 17 Nov 2010, shaohui.zheng@intel.com wrote:
> Index: linux-hpe4/arch/x86/kernel/e820.c
> ===================================================================
> --- linux-hpe4.orig/arch/x86/kernel/e820.c 2010-11-15 17:13:02.483461667 +0800
> +++ linux-hpe4/arch/x86/kernel/e820.c 2010-11-15 17:13:07.083461581 +0800
> @@ -971,6 +971,7 @@
> }
>
> static int userdef __initdata;
> +static u64 max_mem_size __initdata = ULLONG_MAX;
>
> /* "mem=nopentium" disables the 4MB page tables. */
> static int __init parse_memopt(char *p)
> @@ -989,12 +990,28 @@
>
> userdef = 1;
> mem_size = memparse(p, &p);
> - e820_remove_range(mem_size, ULLONG_MAX - mem_size, E820_RAM, 1);
> + e820_remove_range(mem_size, max_mem_size - mem_size, E820_RAM, 1);
> + max_mem_size = mem_size;
>
> return 0;
> }
This needs memmap= support as well, right?
> early_param("mem", parse_memopt);
>
> +#ifdef CONFIG_NODE_HOTPLUG_EMU
> +u64 __init e820_hide_mem(u64 mem_size)
> +{
> + u64 start, end_pfn;
> +
> + userdef = 1;
> + end_pfn = e820_end_of_ram_pfn();
> + start = (end_pfn << PAGE_SHIFT) - mem_size;
> + e820_remove_range(start, max_mem_size - start, E820_RAM, 1);
> + max_mem_size = start;
> +
> + return start;
> +}
> +#endif
This doesn't have any sanity checking for whether e820_remove_range() will
leave any significant amount of memory behind so the kernel will even boot
(probably should have a guaranteed FAKE_NODE_MIN_SIZE left behind?).
> +
> static int __init parse_memmap_opt(char *p)
> {
> char *oldp;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-17 8:16 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 2:07 [0/8,v3] NUMA Hotplug Emulator - Introduction & Feedbacks shaohui.zheng
2010-11-17 2:08 ` [1/8,v3] NUMA Hotplug Emulator: add function to hide memory region via e820 table shaohui.zheng
2010-11-17 8:16 ` David Rientjes [this message]
2010-11-18 9:20 ` Shaohui Zheng
2010-11-18 21:16 ` David Rientjes
2010-11-19 0:12 ` Shaohui Zheng
2010-11-21 0:45 ` David Rientjes
2010-11-21 14:00 ` Américo Wang
2010-11-21 21:33 ` David Rientjes
2010-11-17 2:08 ` [2/8,v3] NUMA Hotplug Emulator: infrastructure of NUMA hotplug emulation shaohui.zheng
2010-11-17 8:16 ` David Rientjes
2010-11-17 7:51 ` Shaohui Zheng
2010-11-17 21:10 ` David Rientjes
2010-11-18 4:14 ` Shaohui Zheng
2010-11-18 6:27 ` Paul Mundt
2010-11-18 5:27 ` Shaohui Zheng
2010-11-18 21:24 ` David Rientjes
2010-11-19 0:32 ` Shaohui Zheng
2010-11-21 0:48 ` David Rientjes
2010-11-21 2:28 ` [patch 1/2] x86: add numa=possible command line option David Rientjes
2010-11-21 2:28 ` [patch 2/2] mm: add node hotplug emulation David Rientjes
2010-11-21 17:34 ` Greg KH
2010-11-21 21:48 ` David Rientjes
2010-11-21 23:08 ` [patch 2/2 v2] " David Rientjes
2010-11-22 0:56 ` Greg KH
2010-11-28 1:52 ` David Rientjes
2010-11-28 5:17 ` Greg KH
2010-11-30 0:04 ` David Rientjes
2010-11-21 14:26 ` [patch 1/2] x86: add numa=possible command line option Américo Wang
2010-11-21 21:46 ` David Rientjes
2010-11-22 15:43 ` Américo Wang
2010-11-21 15:14 ` [2/8,v3] NUMA Hotplug Emulator: infrastructure of NUMA hotplug emulation Li, Haicheng
2010-11-21 21:42 ` David Rientjes
2010-11-18 21:19 ` David Rientjes
2010-11-17 2:08 ` [3/8,v3] NUMA Hotplug Emulator: Userland interface to hotplug-add fake offlined nodes shaohui.zheng
2010-11-17 8:16 ` David Rientjes
2010-11-17 2:08 ` [4/8,v3] NUMA Hotplug Emulator: Abstract cpu register functions shaohui.zheng
2010-11-17 2:08 ` [5/8,v3] NUMA Hotplug Emulator: support cpu probe/release in x86 shaohui.zheng
2010-11-21 14:45 ` Américo Wang
2010-11-22 0:01 ` Shaohui Zheng
2010-11-22 15:51 ` Américo Wang
2010-11-22 23:29 ` Shaohui Zheng
2010-11-17 2:08 ` [6/8,v3] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-11-17 2:08 ` [7/8,v3] NUMA Hotplug Emulator: extend memory probe interface to support NUMA shaohui.zheng
2010-11-17 18:50 ` Dave Hansen
2010-11-17 21:18 ` David Rientjes
2010-11-17 21:55 ` Dave Hansen
2010-11-17 22:44 ` David Rientjes
2010-11-17 23:00 ` Dave Hansen
2010-11-17 23:17 ` David Rientjes
2010-11-18 16:59 ` Aaron Durbin
2010-11-18 4:48 ` Shaohui Zheng
2010-11-18 6:24 ` Paul Mundt
2010-11-18 21:28 ` David Rientjes
2010-11-18 21:31 ` David Rientjes
2010-11-18 4:36 ` Shaohui Zheng
2010-11-19 7:51 ` Shaohui Zheng
2010-11-19 16:36 ` Dave Hansen
2010-11-17 2:08 ` [8/8,v3] NUMA Hotplug Emulator: documentation shaohui.zheng
2010-11-17 23:06 ` Randy Dunlap
2010-11-18 2:31 ` Shaohui Zheng
2010-11-21 15:03 ` Américo Wang
2010-11-21 15:16 ` Li, Haicheng
2010-11-21 23:33 ` Shaohui Zheng
2010-11-22 16:04 ` Américo Wang
2010-11-22 23:23 ` Shaohui Zheng
2010-11-17 5:22 ` [0/8,v3] NUMA Hotplug Emulator - Introduction & Feedbacks Paul Mundt
2010-11-19 5:54 ` Shaohui Zheng
2010-11-17 9:26 ` Yinghai Lu
2010-11-18 2:03 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1011162354390.16875@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=haicheng.li@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@intel.com \
--cc=shaohui.zheng@linux.intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox