From: David Rientjes <rientjes@google.com>
To: Andreas Dilger <andreas.dilger@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Ricardo M. Correia" <ricardo.correia@oracle.com>,
linux-mm@kvack.org, Brian Behlendorf <behlendorf1@llnl.gov>
Subject: Re: Propagating GFP_NOFS inside __vmalloc()
Date: Tue, 16 Nov 2010 23:37:39 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1011162329570.13242@chino.kir.corp.google.com> (raw)
In-Reply-To: <ED9181FA-6B0E-4A7B-AA2D-7B976A876557@oracle.com>
On Wed, 17 Nov 2010, Andreas Dilger wrote:
> >> - avoid doing anything other than GFP_KERNEL allocations for __vmalloc():
> >> the only current users are gfs2, ntfs, and ceph (the page allocator
> >> __vmalloc() can be discounted since it's done at boot and GFP_ATOMIC
> >> here has almost no chance of failing since the size is determined based
> >> on what is available).
> >
> > ^^ this
> >
> > Using vmalloc anywhere is lame.
>
> I agree. What we really want is 1MB kmalloc() to work... :-/
>
Order-8 allocations are already have a higher liklihood of succeeding
because of memory compaction, which was explicitly targeted to aid in
order-9 hugepage allocations. The problem is that it's useless for
GFP_NOFS.
I think removing gfp_t arguments from all of the public vmalloc interface
will inevitably be where we go with this and everything will assume
GFP_KERNEL | __GFP_HIGHMEM.
If you _really_ need 1MB of physically contiguous memory, then you'll need
to find a way to do it in a reclaimable context. If we actually can
remove the dependency that gfs2, ntfs, and ceph have in the kernel.org
kernel, then this support may be pulled out from under you; the worst-case
scenario for Lustre is that you'll have to modify the callchains like I
suggested in my original email to pass the gfp mask all the way down to
the pte allocators if you can't find a way to do it under GFP_KERNEL.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-17 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:42 Ricardo M. Correia
2010-11-10 21:35 ` Ricardo M. Correia
2010-11-10 22:10 ` Dave Chinner
2010-11-11 20:06 ` Andrew Morton
2010-11-11 22:02 ` Ricardo M. Correia
2010-11-11 22:25 ` Andrew Morton
2010-11-11 22:45 ` Ricardo M. Correia
2010-11-11 23:19 ` Ricardo M. Correia
2010-11-11 23:27 ` Andrew Morton
2010-11-11 23:29 ` Ricardo M. Correia
2010-11-15 17:01 ` Ricardo M. Correia
2010-11-15 21:28 ` David Rientjes
2010-11-15 22:19 ` Ricardo M. Correia
2010-11-15 22:50 ` David Rientjes
2010-11-15 23:30 ` Ricardo M. Correia
2010-11-15 23:55 ` David Rientjes
2010-11-16 22:11 ` Andrew Morton
2010-11-17 7:18 ` Andreas Dilger
2010-11-17 7:24 ` Andrew Morton
2010-11-17 7:37 ` David Rientjes [this message]
2010-11-17 9:04 ` Christoph Hellwig
2010-11-17 21:24 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1011162329570.13242@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreas.dilger@oracle.com \
--cc=behlendorf1@llnl.gov \
--cc=linux-mm@kvack.org \
--cc=ricardo.correia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox