From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable"
Date: Mon, 15 Nov 2010 01:59:12 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1011150152490.2986@chino.kir.corp.google.com> (raw)
In-Reply-To: <20101115092238.BEEE.A69D9226@jp.fujitsu.com>
On Mon, 15 Nov 2010, KOSAKI Motohiro wrote:
> At v2.6.36-rc1, oom-killer doesn't work at all because YOU BROKE.
> And I was working on fixing it.
>
> 2010-08-19
> http://marc.info/?t=128223176900001&r=1&w=2
This existed before my oom killer rewrite, it was only noticed because the
rewrite enabled oom_dump_tasks by default.
> http://marc.info/?t=128221532700003&r=1&w=2
Yes, tasklist_lock was dropped in a mismerge of my patches when posting
them. Thanks for finding it and posting a patch, I appreciate it.
> http://marc.info/?t=128221532500008&r=1&w=2
>
Yes, if a task was racing between oom_kill_process() and oom_kill_task()
and all threads had dropped its mm between calls then there was a NULL
pointer dereference, thanks for fixing that as well.
> However, You submitted new crap before the fixing.
>
> 2010-08-15
> http://marc.info/?t=128184669600001&r=1&w=2
>
This isn't "crap", this is a necessary bit to ensure that tasks that share
an ->mm with a task immune from kill aren't killed themselves since we
can't free the memory. We came to the consensus that it would be better
to count the tasks that are OOM_DISABLE in the mm_struct to avoid the
O(2*n) tasklist scan.
> If you tested mainline a bit, you could find the problem quickly.
> You should have fixed mainline kernel at first.
>
Thanks for finding a couple fixes during the 2.6.36-rc1 when the rewrite
was first merged, it's much appreciated!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-15 9:59 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 3:26 [resend][PATCH 1/4] oom: remove totalpage normalization from oom_badness() KOSAKI Motohiro
2010-10-25 3:27 ` [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable" KOSAKI Motohiro
2010-10-25 20:40 ` David Rientjes
2010-10-26 13:01 ` KOSAKI Motohiro
2010-10-26 19:37 ` David Rientjes
2010-11-01 7:06 ` KOSAKI Motohiro
2010-11-01 19:36 ` David Rientjes
2010-11-09 2:26 ` KOSAKI Motohiro
2010-11-09 3:28 ` KOSAKI Motohiro
2010-11-15 0:24 ` KOSAKI Motohiro
2010-11-15 9:59 ` David Rientjes [this message]
2010-11-09 23:33 ` David Rientjes
2010-11-09 23:35 ` Alan Cox
2010-11-09 23:48 ` David Rientjes
2010-11-09 23:55 ` [patch] oom: document obsolete oom_adj tunable David Rientjes
2010-11-15 0:22 ` KOSAKI Motohiro
2010-11-15 10:38 ` David Rientjes
2010-11-23 7:16 ` KOSAKI Motohiro
2010-11-14 5:07 ` [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable" KOSAKI Motohiro
2010-11-14 21:39 ` David Rientjes
2010-11-23 7:16 ` KOSAKI Motohiro
2010-11-28 1:41 ` David Rientjes
2010-11-30 13:03 ` KOSAKI Motohiro
2010-11-30 20:07 ` David Rientjes
2010-10-25 3:28 ` [resend][PATCH 3/4] move cred_guard_mutex from task_struct to signal_struct KOSAKI Motohiro
2010-10-25 17:26 ` Roland McGrath
2010-10-25 17:42 ` Oleg Nesterov
2010-10-25 17:51 ` Roland McGrath
2010-10-26 13:04 ` KOSAKI Motohiro
2010-10-26 13:18 ` Roland McGrath
2010-10-25 3:29 ` [resend][PATCH 4/4] oom: don't ignore rss in nascent mm KOSAKI Motohiro
2010-10-25 11:28 ` pageexec
2010-10-26 7:25 ` KOSAKI Motohiro
2010-11-23 14:34 ` Oleg Nesterov
2010-11-24 0:24 ` KOSAKI Motohiro
2010-11-24 11:09 ` Oleg Nesterov
2010-11-25 11:06 ` KOSAKI Motohiro
2010-11-25 14:02 ` Oleg Nesterov
2010-11-25 19:36 ` Oleg Nesterov
2010-11-29 5:25 ` KOSAKI Motohiro
2010-11-29 11:33 ` Oleg Nesterov
2010-11-29 18:23 ` Oleg Nesterov
2010-11-30 19:54 ` [PATCH 0/2] exec: more excessive argument size fixes for 2.6.37/stable Oleg Nesterov
2010-11-30 19:55 ` [PATCH 1/2] exec: make argv/envp memory visible to oom-killer Oleg Nesterov
2010-12-01 0:12 ` KOSAKI Motohiro
2010-12-01 18:07 ` Oleg Nesterov
2010-11-30 19:56 ` [PATCH 2/2] exec: copy-and-paste the fixes into compat_do_execve() paths Oleg Nesterov
2010-12-01 3:04 ` KOSAKI Motohiro
2010-11-30 20:00 ` [PATCH 0/4] exec: unify compat/non-compat code Oleg Nesterov
2010-11-30 20:00 ` [PATCH 1/4] exec: introduce get_arg_ptr() helper Oleg Nesterov
2010-11-30 20:01 ` [PATCH 2/4] exec: introduce "bool compat" argument Oleg Nesterov
2010-11-30 20:01 ` [PATCH 3/4] exec: unify compat_do_execve() code Oleg Nesterov
2010-12-01 17:37 ` (No subject header) Milton Miller
2010-12-01 18:27 ` Oleg Nesterov
2011-02-25 17:52 ` [PATCH 0/4 RESEND] exec: unify compat/non-compat code Oleg Nesterov
2011-02-25 17:52 ` [PATCH 1/5] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-02-25 17:52 ` [PATCH 2/5] exec: introduce "bool compat" argument Oleg Nesterov
2011-02-25 18:57 ` Linus Torvalds
2011-02-26 12:37 ` Oleg Nesterov
2011-02-25 17:53 ` [PATCH 3/5] exec: unify compat_do_execve() code Oleg Nesterov
2011-02-25 19:10 ` Linus Torvalds
2011-02-26 12:37 ` Oleg Nesterov
2011-02-26 12:57 ` Oleg Nesterov
2011-02-26 15:55 ` Linus Torvalds
2011-02-26 17:44 ` Oleg Nesterov
2011-03-01 20:47 ` [PATCH v2 0/5] exec: unify native/compat code Oleg Nesterov
2011-03-01 20:48 ` [PATCH v2 1/5] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-03-01 20:48 ` [PATCH v2 2/5] exec: introduce "bool compat" argument Oleg Nesterov
2011-03-01 20:48 ` [PATCH v2 3/5] exec: introduce conditional_user_ptr_t Oleg Nesterov
2011-03-01 20:49 ` [PATCH v2 4/5] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-01 20:49 ` [PATCH v2 5/5] exec: document acct_arg_size() Oleg Nesterov
2011-03-01 21:39 ` [PATCH v2 0/5] exec: unify native/compat code Linus Torvalds
2011-03-02 16:26 ` [PATCH v3 0/4] " Oleg Nesterov
2011-03-02 16:27 ` [PATCH v3 1/4] exec: introduce get_arg_ptr() helper Oleg Nesterov
2011-03-03 3:01 ` KOSAKI Motohiro
2011-03-03 15:47 ` Oleg Nesterov
2011-03-03 16:07 ` Linus Torvalds
2011-03-05 20:30 ` [PATCH v4 0/4] exec: unify native/compat code Oleg Nesterov
2011-03-05 20:31 ` [PATCH v4 1/4] exec: introduce get_user_arg_ptr() helper Oleg Nesterov
2011-03-05 20:31 ` [PATCH v4 2/4] exec: introduce struct user_arg_ptr Oleg Nesterov
2011-03-05 20:31 ` [PATCH v4 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-05 20:52 ` Linus Torvalds
2011-03-05 21:20 ` Oleg Nesterov
2011-03-05 20:31 ` [PATCH v4 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-06 12:04 ` [PATCH v4 0/4] exec: unify native/compat code KOSAKI Motohiro
2011-03-06 17:01 ` [PATCH v5 " Oleg Nesterov
2011-03-06 17:02 ` [PATCH v5 1/4] exec: introduce get_user_arg_ptr() helper Oleg Nesterov
2011-03-06 17:02 ` [PATCH v5 2/4] exec: introduce struct user_arg_ptr Oleg Nesterov
2011-03-06 17:02 ` [PATCH v5 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-06 17:03 ` [PATCH v5 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-02 16:27 ` [PATCH v3 2/4] exec: introduce struct conditional_ptr Oleg Nesterov
2011-03-03 3:08 ` KOSAKI Motohiro
2011-03-02 16:27 ` [PATCH v3 3/4] exec: unify do_execve/compat_do_execve code Oleg Nesterov
2011-03-03 3:13 ` KOSAKI Motohiro
2011-03-02 16:28 ` [PATCH v3 4/4] exec: document acct_arg_size() Oleg Nesterov
2011-03-03 3:09 ` KOSAKI Motohiro
2011-03-02 16:44 ` [PATCH v3 0/4] exec: unify native/compat code Oleg Nesterov
2011-03-02 18:00 ` Linus Torvalds
2011-03-02 19:40 ` David Miller
2011-03-02 19:48 ` Linus Torvalds
2011-03-02 19:54 ` David Miller
2011-02-25 17:53 ` [PATCH 4/5] exec: unexport acct_arg_size() and get_arg_page() Oleg Nesterov
2011-02-25 17:54 ` [PATCH 5/5] exec: document acct_arg_size() Oleg Nesterov
2011-02-25 18:54 ` [PATCH 0/4 RESEND] exec: unify compat/non-compat code Linus Torvalds
2011-02-26 12:35 ` Oleg Nesterov
2010-11-30 20:01 ` [PATCH 4/4] exec: unexport acct_arg_size() and get_arg_page() Oleg Nesterov
2010-12-01 3:09 ` [PATCH 0/4] exec: unify compat/non-compat code KOSAKI Motohiro
2010-11-30 0:06 ` [resend][PATCH 4/4] oom: don't ignore rss in nascent mm KOSAKI Motohiro
2010-10-25 20:37 ` [resend][PATCH 1/4] oom: remove totalpage normalization from oom_badness() David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1011150152490.2986@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox