From: David Rientjes <rientjes@google.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org, Ken Chen <kenchen@google.com>
Subject: Re: [PATCH v3] fix __set_page_dirty_no_writeback() return value
Date: Thu, 11 Nov 2010 00:40:04 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1011110039210.16401@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011102340450.7571@chino.kir.corp.google.com>
On Wed, 10 Nov 2010, David Rientjes wrote:
> > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > index bf85062..1ebfb86 100644
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -1158,7 +1158,7 @@ EXPORT_SYMBOL(write_one_page);
> > int __set_page_dirty_no_writeback(struct page *page)
> > {
> > if (!PageDirty(page))
> > - SetPageDirty(page);
> > + return !TestSetPageDirty(page);
> > return 0;
> > }
>
> No need for a conditional, just return !TestSetPageDirty(page).
>
Oops, just read Andrew's reply to v1 of the patch about the cacheline
invalidation of bts, sorry for the noise.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-11-11 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:26 Bob Liu
2010-11-11 7:50 ` David Rientjes
2010-11-11 8:40 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1011110039210.16401@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox