From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id C25746B006A for ; Tue, 5 Oct 2010 14:32:14 -0400 (EDT) Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id o95IW2W9004532 for ; Tue, 5 Oct 2010 11:32:02 -0700 Received: from pxi11 (pxi11.prod.google.com [10.243.27.11]) by hpaq14.eem.corp.google.com with ESMTP id o95IVvo7021634 for ; Tue, 5 Oct 2010 11:32:00 -0700 Received: by pxi11 with SMTP id 11so2087596pxi.34 for ; Tue, 05 Oct 2010 11:31:59 -0700 (PDT) Date: Tue, 5 Oct 2010 11:31:57 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 08/10] memcg: add cgroupfs interface to memcg dirty limits In-Reply-To: <20101005091836.GA1698@linux.develer.com> Message-ID: References: <1286175485-30643-1-git-send-email-gthelen@google.com> <1286175485-30643-9-git-send-email-gthelen@google.com> <20101005161340.9bb7382e.kamezawa.hiroyu@jp.fujitsu.com> <20101005091836.GA1698@linux.develer.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Andrea Righi Cc: Greg Thelen , KAMEZAWA Hiroyuki , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, containers@lists.osdl.org, Balbir Singh , Daisuke Nishimura List-ID: On Tue, 5 Oct 2010, Andrea Righi wrote: > mmh... looking at the code it seems the same behaviour, but in > Documentation/sysctl/vm.txt we say a different thing (i.e., for > dirty_bytes): > > "If dirty_bytes is written, dirty_ratio becomes a function of its value > (dirty_bytes / the amount of dirtyable system memory)." > > However, in dirty_bytes_handler()/dirty_ratio_handler() we actually set > the counterpart value as 0. > > I think we should clarify the documentation. > > Signed-off-by: Andrea Righi Acked-by: David Rientjes Thanks for cc'ing me on this, Andrea. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org