From: David Rientjes <rientjes@google.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-mm@kvack.org
Subject: Re: [Slub cleanup5 2/3] SLUB: Pass active and inactive redzone flags instead of boolean to debug functions
Date: Tue, 28 Sep 2010 17:38:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1009281733430.9704@chino.kir.corp.google.com> (raw)
In-Reply-To: <20100928131057.084357922@linux.com>
On Tue, 28 Sep 2010, Christoph Lameter wrote:
> @@ -1075,8 +1071,9 @@ static inline int free_debug_processing(
> static inline int slab_pad_check(struct kmem_cache *s, struct page *page)
> { return 1; }
> static inline int check_object(struct kmem_cache *s, struct page *page,
> - void *object, int active) { return 1; }
> -static inline void add_full(struct kmem_cache_node *n, struct page *page) {}
> + void *object, u8 val) { return 1; }
> +static inline void add_full(struct kmem_cache *s,
> + struct kmem_cache_node *n, struct page *page) {}
> static inline unsigned long kmem_cache_flags(unsigned long objsize,
> unsigned long flags, const char *name,
> void (*ctor)(void *))
Looks like add_full() got changed there for CONFIG_SLUB_DEBUG=n
unintentionally.
I'm wondering if we should make that option configurable regardless of
CONFIG_EMBEDDED, it's a large savings if you're never going to be doing
any debugging on Pekka's for-next:
text data bss dec hex filename
25817 1473 288 27578 6bba slub.o.debug
10742 232 256 11230 2bde slub.o.nodebug
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-29 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 13:10 [Slub cleanup5 0/3] SLUB: Cleanups V5 Christoph Lameter
2010-09-28 13:10 ` [Slub cleanup5 1/3] slub: reduce differences between SMP and NUMA Christoph Lameter
2010-09-28 14:34 ` Pekka Enberg
2010-09-28 14:43 ` Christoph Lameter
2010-09-29 0:33 ` David Rientjes
2010-09-28 13:10 ` [Slub cleanup5 2/3] SLUB: Pass active and inactive redzone flags instead of boolean to debug functions Christoph Lameter
2010-09-29 0:38 ` David Rientjes [this message]
2010-09-29 12:15 ` Christoph Lameter
2010-09-29 20:01 ` David Rientjes
2010-09-28 13:10 ` [Slub cleanup5 3/3] slub: extract common code to remove objects from partial list without locking Christoph Lameter
2010-09-29 0:38 ` David Rientjes
2010-10-02 8:50 ` [Slub cleanup5 0/3] SLUB: Cleanups V5 Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1009281733430.9704@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox