From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Kulikov Vasiliy <segooon@gmail.com>,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 14/14] mm: oom_kill: use IS_ERR() instead of strict checking
Date: Mon, 6 Sep 2010 01:59:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1009060155250.10552@chino.kir.corp.google.com> (raw)
In-Reply-To: <20100906094555.C8BB.A69D9226@jp.fujitsu.com>
On Mon, 6 Sep 2010, KOSAKI Motohiro wrote:
> > From: Vasiliy Kulikov <segooon@gmail.com>
> >
> > Use IS_ERR() instead of strict checking.
>
> Umm...
>
> I don't like this. IS_ERR() imply an argument is error code. but in
> this case, we don't use error code. -1 mean oom special purpose meaning
> value.
>
You could make the same argument by saying the current use of PTR_ERR()
implies an error code. We've simply hijacked -1UL for simplicity in this
case and because select_bad_process() can only return one other value
besides a pointer to a process or NULL.
> So, if we take this direction, It would be better to use EAGAIN or something
> instead -1.
>
I agree it would probably better to return ERR_PTR(-EAGAIN) instead of
using -1UL.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-09-06 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 18:33 Kulikov Vasiliy
2010-09-05 22:00 ` David Rientjes
2010-09-06 0:48 ` KOSAKI Motohiro
2010-09-06 8:59 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1009060155250.10552@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox