From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 9969A6007EE for ; Mon, 23 Aug 2010 12:08:12 -0400 (EDT) Date: Mon, 23 Aug 2010 11:08:06 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH v5 03/12] Add async PF initialization to PV guest. In-Reply-To: <20100823153549.GU10499@redhat.com> Message-ID: References: <1279553462-7036-1-git-send-email-gleb@redhat.com> <1279553462-7036-4-git-send-email-gleb@redhat.com> <4C729342.6070205@redhat.com> <20100823153549.GU10499@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Gleb Natapov Cc: Avi Kivity , kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com, riel@redhat.com, mtosatti@redhat.com List-ID: On Mon, 23 Aug 2010, Gleb Natapov wrote: > > The guest will have to align this on a 64 byte boundary, should this > > be marked __aligned(64) here? > > > I do __aligned(64) when I declare variable of that type: > > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); 64 byte boundary: You mean cacheline aligned? We have a special define for that. DEFINE_PER_CPU_SHARED_ALIGNED -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org