From: Christoph Lameter <cl@linux.com>
To: David Rientjes <rientjes@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-mm@kvack.org
Subject: Re: [S+Q Cleanup3 4/6] slub: Dynamically size kmalloc cache allocations
Date: Fri, 20 Aug 2010 12:08:16 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1008201206390.32757@router.home> (raw)
In-Reply-To: <alpine.DEB.2.00.1008191638390.29676@chino.kir.corp.google.com>
On Thu, 19 Aug 2010, David Rientjes wrote:
> On Thu, 19 Aug 2010, Christoph Lameter wrote:
>
> > Right. I will merge this correctly for the next release that has all
> > patches acked by you.
> >
>
> It would really be nice to get rid of all the #ifdefs in kmem_cache_init()
> for CONFIG_NUMA by extracting them to helper functions if you're
> interested.
That is difficult since the code segments share global and local
variables. Also the location of the kmem_cache_node structure
differs since it is embedded in the SMP case. We could just drop that
optimization. Then it would be easy to drop lots of NUMA specifics in the
allocator.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-20 17:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 20:33 [S+Q Cleanup3 0/6] SLUB: Cleanups V3 Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 1/6] Slub: Force no inlining of debug functions Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 2/6] slub: remove dynamic dma slab allocation Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 3/6] slub: Remove static kmem_cache_cpu array for boot Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 4/6] slub: Dynamically size kmalloc cache allocations Christoph Lameter
2010-08-19 21:21 ` David Rientjes
2010-08-19 21:31 ` Christoph Lameter
2010-08-19 23:01 ` David Rientjes
2010-08-19 23:20 ` Christoph Lameter
2010-08-19 23:39 ` David Rientjes
2010-08-20 17:08 ` Christoph Lameter [this message]
2010-08-20 17:32 ` Christoph Lameter
2010-09-28 10:06 ` David Rientjes
2010-09-28 12:42 ` Christoph Lameter
2010-08-19 20:33 ` [S+Q Cleanup3 5/6] slub: Extract hooks for memory checkers from hotpaths Christoph Lameter
2010-08-19 21:02 ` David Rientjes
2010-08-19 20:33 ` [S+Q Cleanup3 6/6] slub: Move gfpflag masking out of the hotpath Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1008201206390.32757@router.home \
--to=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox