From: Christoph Lameter <cl@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-mm@kvack.org
Subject: Re: [S+Q Cleanup 6/6] slub: Move gfpflag masking out of the hotpath
Date: Wed, 18 Aug 2010 10:46:22 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1008180958420.4025@router.home> (raw)
In-Reply-To: <alpine.DEB.2.00.1008171734150.21514@chino.kir.corp.google.com>
On Tue, 17 Aug 2010, David Rientjes wrote:
> > + gfpflags &= gfp_allowed_mask;
> > if (gfpflags & __GFP_WAIT)
> > local_irq_enable();
> >
>
> Couldn't this include the masking of __GFP_ZERO at the beginning of
> __slab_alloc()?
We could move it together but then the masking of GFP_ZERO has never done
anything and AFAICT is there because some people felt unsafe with the
masking already done nearer to the page alloc functions.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-08-18 15:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 21:11 [S+Q Cleanup 0/6] SLUB: Cleanups Christoph Lameter
2010-08-17 21:11 ` [S+Q Cleanup 1/6] Slub: Force no inlining of debug functions Christoph Lameter
2010-08-17 23:13 ` David Rientjes
2010-08-17 21:11 ` [S+Q Cleanup 2/6] slub: remove dynamic dma slab allocation Christoph Lameter
2010-08-17 23:35 ` David Rientjes
2010-08-18 14:46 ` Christoph Lameter
2010-08-17 21:11 ` [S+Q Cleanup 3/6] slub: Remove static kmem_cache_cpu array for boot Christoph Lameter
2010-08-17 23:58 ` David Rientjes
2010-08-18 6:09 ` Tejun Heo
2010-08-18 14:54 ` Christoph Lameter
2010-08-17 21:11 ` [S+Q Cleanup 4/6] slub: Dynamically size kmalloc cache allocations Christoph Lameter
2010-08-17 21:11 ` [S+Q Cleanup 5/6] slub: Extract hooks for memory checkers from hotpaths Christoph Lameter
2010-08-18 0:28 ` David Rientjes
2010-08-18 14:58 ` Christoph Lameter
2010-08-17 21:11 ` [S+Q Cleanup 6/6] slub: Move gfpflag masking out of the hotpath Christoph Lameter
2010-08-18 0:35 ` David Rientjes
2010-08-18 15:46 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1008180958420.4025@router.home \
--to=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox