From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id EEBE56B024C for ; Tue, 6 Jul 2010 16:48:10 -0400 (EDT) Date: Tue, 6 Jul 2010 15:44:45 -0500 (CDT) From: Christoph Lameter Subject: Re: [S+Q 07/16] slub: discard_slab_unlock In-Reply-To: Message-ID: References: <20100625212026.810557229@quilx.com> <20100625212105.203196516@quilx.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Pekka Enberg , linux-mm@kvack.org, Nick Piggin , Matt Mackall List-ID: On Sat, 26 Jun 2010, David Rientjes wrote: > > The sequence of unlocking a slab and freeing occurs multiple times. > > Put the common into a single function. > > > > Did you want to respond to the comments I made about this patch at > http://marc.info/?l=linux-mm&m=127689747432061 ? Specifically, how it > makes seeing if there are unmatched slab_lock() -> slab_unlock() pairs > more difficult. I dont think so. The name includes slab_unlock at the end. We could drop this but its a frequent action necessary when disposing of a slab page. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org