linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	penberg@cs.helsinki.fi, mpm@selenic.com
Subject: Re: [PATCH] Slabinfo: Fix display format
Date: Thu, 17 Jun 2010 08:45:09 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1006170844300.22997@router.home> (raw)
In-Reply-To: <20100617155420.GB2693@localhost.localdomain>

On Thu, 17 Jun 2010, wzt.wzt@gmail.com wrote:

> @@ -4271,7 +4271,7 @@ static int s_show(struct seq_file *m, void *p)
>  	if (error)
>  		printk(KERN_ERR "slab: cache %s error: %s\n", name, error);
>
> -	seq_printf(m, "%-17s %6lu %6lu %6u %4u %4d",
> +	seq_printf(m, "%-27s %6lu %6lu %6u %4u %4d",
>  		   name, active_objs, num_objs, cachep->buffer_size,
>  		   cachep->num, (1 << cachep->gfporder));
>  	seq_printf(m, " : tunables %4u %4u %4u",

This one may break user space tools that have assumptions about the length
of the field. Or do tools not make that assumption?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-06-17 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 15:54 wzt.wzt
2010-06-17 13:45 ` Christoph Lameter [this message]
2010-06-17 14:10   ` wzt wzt
2010-06-18  6:09     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1006170844300.22997@router.home \
    --to=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=wzt.wzt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox