linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@linux.com>, linux-mm@kvack.org
Subject: [patch 3/4] slub: use is_kmalloc_cache in dma_kmalloc_cache
Date: Tue, 8 Jun 2010 23:49:10 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1006082348310.30606@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1006082347440.30606@chino.kir.corp.google.com>

dma_kmalloc_cache() can use the new is_kmalloc_cache() helper function.

Also removes an unnecessary assignment to local variable `s'.

Cc: Christoph Lameter <cl@linux.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/slub.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2649,13 +2649,12 @@ static noinline struct kmem_cache *dma_kmalloc_cache(int index, gfp_t flags)
 	text = kasprintf(flags & ~SLUB_DMA, "kmalloc_dma-%d",
 			 (unsigned int)realsize);
 
-	s = NULL;
 	for (i = 0; i < KMALLOC_CACHES; i++)
 		if (!kmalloc_caches[i].size)
 			break;
 
-	BUG_ON(i >= KMALLOC_CACHES);
 	s = kmalloc_caches + i;
+	BUG_ON(!is_kmalloc_cache(s));
 
 	/*
 	 * Must defer sysfs creation to a workqueue because we don't know

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-06-09  6:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09  6:49 [patch 1/4] slub: replace SLAB_NODE_UNSPECIFIED with NUMA_NO_NODE David Rientjes
2010-06-09  6:49 ` [patch 2/4] slub: rename debug_on to cache_debug_on David Rientjes
2010-06-09 16:20   ` Christoph Lameter
2010-06-09  6:49 ` David Rientjes [this message]
2010-06-09 16:24   ` [patch 3/4] slub: use is_kmalloc_cache in dma_kmalloc_cache Christoph Lameter
2010-06-09 19:47     ` David Rientjes
2010-06-09  6:49 ` [patch 4/4] slub: remove gfp_flags argument from create_kmalloc_cache David Rientjes
2010-06-09 16:24   ` Christoph Lameter
2010-06-09 16:44     ` Pekka Enberg
2010-06-15 17:33       ` Christoph Lameter
2010-06-15 21:39         ` David Rientjes
2010-06-16 15:26           ` Christoph Lameter
2010-06-09 16:18 ` [patch 1/4] slub: replace SLAB_NODE_UNSPECIFIED with NUMA_NO_NODE Christoph Lameter
2010-06-09 16:44   ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1006082348310.30606@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox