From: Christoph Lameter <cl@linux-foundation.org>
To: "Shi, Alex" <alex.shi@intel.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: RE: [PATCH] slub: move kmem_cache_node into it's own cacheline
Date: Fri, 21 May 2010 13:03:51 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1005211301510.14851@router.home> (raw)
In-Reply-To: <6E3BC7F7C9A4BF4286DD4C043110F30B0B5969081B@shsmsx502.ccr.corp.intel.com>
Yes right. The cacheline that also contains local_node is dirtied by the
locking in the SMP case and will evict the cacheline used to lookup the
per cpu vector and other important information. The per cpu patches
aggravated that problem by making more use of the fields that are evicted
with the cacheline.
Acked-by: Christoph Lameter <cl@linux-foundation.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-21 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 23:47 Alexander Duyck
2010-05-21 4:59 ` Pekka Enberg
2010-05-21 14:41 ` Shi, Alex
2010-05-21 18:03 ` Christoph Lameter [this message]
2010-05-24 18:14 ` Pekka Enberg
2010-05-26 0:52 ` Shi, Alex
2010-05-21 18:06 ` Christoph Lameter
2010-05-21 18:17 ` Duyck, Alexander H
2010-05-21 18:24 ` Christoph Lameter
2010-05-21 18:33 ` Christoph Lameter
2010-05-21 20:23 ` Duyck, Alexander H
2010-05-21 20:41 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1005211301510.14851@router.home \
--to=cl@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=tim.c.chen@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox