From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 4F2DE6B01EE for ; Wed, 21 Apr 2010 10:17:09 -0400 (EDT) Date: Wed, 21 Apr 2010 09:15:52 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages In-Reply-To: <20100420150522.GG19264@csn.ul.ie> Message-ID: References: <4BC6CB30.7030308@kernel.org> <4BC6E581.1000604@kernel.org> <4BC6FBC8.9090204@kernel.org> <1271606079.2100.159.camel@barrios-desktop> <4BCCD8BD.1020307@kernel.org> <20100420150522.GG19264@csn.ul.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Tejun Heo , Minchan Kim , Andrew Morton , KAMEZAWA Hiroyuki , Bob Liu , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 20 Apr 2010, Mel Gorman wrote: > alloc_pages_exact_node() avoids a branch in a hot path that is checking for > something the caller already knows. That's the reason it exists. We can avoid alloc_pages_exact_node() by making all callers of alloc_pages_node() never use -1. -1 is ambiguous and only rarely will a caller pass that to alloc_pages_node(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org