From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 85DDF6B0215 for ; Fri, 9 Apr 2010 12:49:16 -0400 (EDT) Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id o39GnAgL010079 for ; Fri, 9 Apr 2010 09:49:11 -0700 Received: from pwj8 (pwj8.prod.google.com [10.241.219.72]) by wpaz29.hot.corp.google.com with ESMTP id o39Gn86D020354 for ; Fri, 9 Apr 2010 09:49:09 -0700 Received: by pwj8 with SMTP id 8so1951370pwj.10 for ; Fri, 09 Apr 2010 09:49:08 -0700 (PDT) Date: Fri, 9 Apr 2010 09:49:05 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING In-Reply-To: <4BBEC92B.9060407@redhat.com> Message-ID: References: <1270721493-27820-1-git-send-email-dfeng@redhat.com> <4BBEC92B.9060407@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Xiaotian Feng Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , Matt Mackall , Vegard Nossum , Dmitry Monakhov , Catalin Marinas List-ID: On Fri, 9 Apr 2010, Xiaotian Feng wrote: > > This doesn't work if the underlying slab allocator doesn't define > > __kmalloc_node_track_caller() regardless of whether CONFIG_TRACING is > > enabled or not. SLOB, for example, never defines it, and that's why the > > conditional exists in the way it currently does. > > > > Sorry, I didn't realized this, can we use (defined(CONFIG_TRACING) && > defined(CONFIG_SLAB)) ? > The valid configurations are (CONFIG_SLAB && (CONFIG_DEBUG_SLAB || CONFIG_TRACING)) || CONFIG_SLUB -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org