From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 74EB66B01EF for ; Thu, 1 Apr 2010 15:05:02 -0400 (EDT) Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [10.3.21.5]) by smtp-out.google.com with ESMTP id o31J4xKt023124 for ; Thu, 1 Apr 2010 12:04:59 -0700 Received: from pwj10 (pwj10.prod.google.com [10.241.219.74]) by hpaq5.eem.corp.google.com with ESMTP id o31J4gvq005035 for ; Thu, 1 Apr 2010 21:04:57 +0200 Received: by pwj10 with SMTP id 10so1223626pwj.40 for ; Thu, 01 Apr 2010 12:04:56 -0700 (PDT) Date: Thu, 1 Apr 2010 12:04:54 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH -mm] proc: don't take ->siglock for /proc/pid/oom_adj In-Reply-To: <20100401153756.GD14603@redhat.com> Message-ID: References: <20100329112111.GA16971@redhat.com> <20100330163909.GA16884@redhat.com> <20100330174337.GA21663@redhat.com> <20100331185950.GB11635@redhat.com> <20100331230032.GB4025@redhat.com> <20100401153756.GD14603@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Oleg Nesterov Cc: Andrew Morton , anfei , KOSAKI Motohiro , nishimura@mxp.nes.nec.co.jp, KAMEZAWA Hiroyuki , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Thu, 1 Apr 2010, Oleg Nesterov wrote: > But. Unless we kill signal->oom_adj, we have another reason for ->siglock, > we can't update both oom_adj and oom_score_adj atomically, and if we race > with another thread they can be inconsistent wrt each other. Yes, oom_adj > is not actually used, except we report it back to user-space, but still. > > So, I am going to send 2 patches. The first one factors out the code > in base.c and kills signal->oom_adj, the next one removes ->siglock. > Great, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org