From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 7C3876B00CB for ; Tue, 9 Mar 2010 15:55:49 -0500 (EST) Date: Tue, 9 Mar 2010 14:55:39 -0600 (CST) From: Christoph Lameter Subject: Re: mm: Do not iterate over NR_CPUS in __zone_pcp_update() In-Reply-To: Message-ID: References: <20100309122253.3f3d4a53.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: "Robert P. J. Day" Cc: Andrew Morton , Thomas Gleixner , LKML , linux-mm@kvack.org, Pekka Enberg List-ID: On Tue, 9 Mar 2010, Robert P. J. Day wrote: > > I'm having trouble working out whether we want to backport this into > > 2.6.33.x or earlier. Help? > > given the above aesthetic mod, shouldn't that same change be applied > to *all* explicit loops of that form? after all, checkpatch.pl warns > against it: The number of NR_CPUS should be significantly less after the percpu rework. Would you audit the kernel for NR_CPUS use? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org