From: David Rientjes <rientjes@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Nick Piggin <npiggin@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [patch -mm v2 04/10] oom: remove special handling for pagefault ooms
Date: Wed, 3 Mar 2010 15:27:53 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1003031527230.32530@chino.kir.corp.google.com> (raw)
In-Reply-To: <20100303095812.c3d47ee1.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, 3 Mar 2010, KAMEZAWA Hiroyuki wrote:
> In patch 01-03, you don't modified panic_on_oom implementation.
> And this patch, you don't modified the return code of memcg's charge code.
> It still returns -ENOMEM.
>
> Then, VM_FAULT_OOM is returned and page_fault_out_of_memory() calles this
> and hit this.
>
> case CONSTRAINT_NONE:
> if (sysctl_panic_on_oom) {
> dump_header(NULL, gfp_mask, order, NULL);
> panic("out of memory. panic_on_oom is selected\n");
> }
>
> The system will panic. A hook, mem_cgroup_oom_called() is for avoiding this.
> memcg's oom doesn't mean memory shortage, just means it his limit.
>
And this is fixed by memcg-fix-oom-kill-behavior-v3.patch in -mm, right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-03 23:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 23:52 [patch -mm v2 00/10] oom killer rewrite David Rientjes
2010-02-26 23:53 ` [patch -mm v2 01/10] oom: filter tasks not sharing the same cpuset David Rientjes
2010-03-02 4:54 ` Balbir Singh
2010-02-26 23:53 ` [patch -mm v2 02/10] oom: sacrifice child with highest badness score for parent David Rientjes
2010-03-02 4:54 ` Balbir Singh
2010-02-26 23:53 ` [patch -mm v2 03/10] oom: select task from tasklist for mempolicy ooms David Rientjes
2010-02-26 23:53 ` [patch -mm v2 04/10] oom: remove special handling for pagefault ooms David Rientjes
2010-03-01 1:12 ` KAMEZAWA Hiroyuki
2010-03-01 10:13 ` David Rientjes
2010-03-01 23:59 ` KAMEZAWA Hiroyuki
2010-03-02 23:55 ` David Rientjes
2010-03-03 0:24 ` KAMEZAWA Hiroyuki
2010-03-03 0:44 ` David Rientjes
2010-03-01 5:23 ` Balbir Singh
2010-03-01 10:04 ` David Rientjes
2010-03-01 23:55 ` KAMEZAWA Hiroyuki
2010-03-03 0:01 ` David Rientjes
2010-03-03 0:22 ` KAMEZAWA Hiroyuki
2010-03-03 0:38 ` David Rientjes
2010-03-03 0:44 ` KAMEZAWA Hiroyuki
2010-03-03 0:53 ` David Rientjes
2010-03-03 0:58 ` KAMEZAWA Hiroyuki
2010-03-03 23:27 ` David Rientjes [this message]
2010-03-04 3:59 ` KAMEZAWA Hiroyuki
2010-03-04 6:50 ` David Rientjes
2010-03-04 7:00 ` KAMEZAWA Hiroyuki
2010-03-04 9:50 ` David Rientjes
2010-03-05 0:58 ` KAMEZAWA Hiroyuki
2010-03-02 2:21 ` KAMEZAWA Hiroyuki
2010-03-02 23:59 ` David Rientjes
2010-02-26 23:53 ` [patch -mm v2 05/10] oom: badness heuristic rewrite David Rientjes
2010-02-26 23:53 ` [patch -mm v2 06/10] oom: deprecate oom_adj tunable David Rientjes
2010-02-26 23:53 ` [patch -mm v2 07/10] oom: replace sysctls with quick mode David Rientjes
2010-02-26 23:53 ` [patch -mm v2 08/10] oom: avoid oom killer for lowmem allocations David Rientjes
2010-02-26 23:53 ` [patch -mm v2 09/10] oom: remove unnecessary code and cleanup David Rientjes
2010-02-26 23:53 ` [patch -mm v2 10/10] oom: default to killing current for pagefault ooms David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1003031527230.32530@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox