From: David Rientjes <rientjes@google.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-mm@kvack.org, akinobu.mita@gmail.com,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 2/2] failslab: add ability to filter slab caches [v2]
Date: Thu, 25 Feb 2010 16:55:02 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1002251652190.5560@chino.kir.corp.google.com> (raw)
In-Reply-To: <1267078900-4626-2-git-send-email-dmonakhov@openvz.org>
On Thu, 25 Feb 2010, Dmitry Monakhov wrote:
> @@ -1020,6 +1021,11 @@ static int __init setup_slub_debug(char *str)
> case 't':
> slub_debug |= SLAB_TRACE;
> break;
> +#ifdef CONFIG_FAILSLAB
> + case 'a':
> + slub_debug |= SLAB_FAILSLAB;
> + break;
> +#endif
> default:
> printk(KERN_ERR "slub_debug option '%c' "
> "unknown. skipped\n", *str);
The #ifdef is unnecessary, SLAB_FAILSLAB is 0x0 when CONFIG_FAILSLAB isn't
set.
When that's changed, feel free to add my:
Acked-by: David Rientjes <rientjes@google.com>
and send an updated version to Pekka Enberg <penberg@cs.helsinki.fi> and
cc Christoph Lameter <cl@linux-foundation.org>.
I guess 'A' is the best letter to use for `slub_debug' (fAil slab? :)
since 'F' is already used.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-26 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 6:21 [PATCH 1/2] slab: fix kmem_cache definition Dmitry Monakhov
2010-02-25 6:21 ` [PATCH 2/2] failslab: add ability to filter slab caches [v2] Dmitry Monakhov
2010-02-26 0:55 ` David Rientjes [this message]
2010-02-26 0:34 ` [PATCH 1/2] slab: fix kmem_cache definition David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1002251652190.5560@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akinobu.mita@gmail.com \
--cc=cl@linux-foundation.org \
--cc=dmonakhov@openvz.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox