From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 1D3F86B0047 for ; Fri, 5 Feb 2010 15:56:31 -0500 (EST) Date: Fri, 5 Feb 2010 14:55:20 -0600 (CST) From: Christoph Lameter Subject: Re: [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues In-Reply-To: <87636bv3eq.fsf@basil.nowhere.org> Message-ID: References: <201002031039.710275915@firstfloor.org> <87636bv3eq.fsf@basil.nowhere.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: linux-kernel@vger.kernel.org, haicheng.li@intel.com, penberg@cs.helsinki.fi, linux-mm@kvack.org List-ID: On Fri, 5 Feb 2010, Andi Kleen wrote: > > It changes the bootstrap semantics. The requirement was so far that slab > > initialization must be complete before slab operations can be used. > > The problem is that slab itself uses slab it initialize itself. slab uses itself and also the page allocator to bootstrap itself. The sequence was always a bit fragile. The page allocator also needs to use the slab allocator in turn to bootstrap itself. > > This patchset allows such use before bootstrap on a node is complete and > > also allows the running of cache reaper before bootstrap is done. > > > > I have a bad feeling that this could be the result of Pekka's changes to > > the bootstrap. > > Not sure I fully follow what you're saying. > > Are you saying this is a regression fix after all? I am saying that we may have more trouble lurking here. If we fix it this way then the bootstrap of a node is different from system bootstrap that so far does not need these special measures. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org