From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 491336B006A for ; Fri, 15 Jan 2010 18:32:56 -0500 (EST) Date: Fri, 15 Jan 2010 17:32:45 -0600 (CST) From: Christoph Lameter Subject: Re: SLUB ia64 linux-next crash bisected to 756dee75 In-Reply-To: <1263587721.20615.255.camel@useless.americas.hpqcorp.net> Message-ID: References: <20100113002923.GF2985@ldl.fc.hp.com> <1263587721.20615.255.camel@useless.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Lee Schermerhorn Cc: Alex Chiang , penberg@cs.helsinki.fi, linux-ia64@vger.kernel.org, linux-mm@kvack.org List-ID: On Fri, 15 Jan 2010, Lee Schermerhorn wrote: > > The following patch makes init_kmem_cache_nodes assume 0 > > for statically allocated kmem_cache structures even after > > boot is complete. > > I believe that on Alex's platform, the kernel will get loaded into "node > 2", the hardware interleaved pseudo-node, because it's located at phys > 0..., and has sufficient space. So, this might not work here. Hmm. thats gets us into some strange issues. > > Index: linux-2.6/mm/slub.c > > =================================================================== > > --- linux-2.6.orig/mm/slub.c 2010-01-15 14:02:54.000000000 -0600 > > +++ linux-2.6/mm/slub.c 2010-01-15 14:04:47.000000000 -0600 > > @@ -2176,7 +2176,8 @@ static int init_kmem_cache_nodes(struct > > int node; > > int local_node; > > > > - if (slab_state >= UP) > > + if (slab_state >= UP && > > > > s < kmalloc_caches && > > + s > kmalloc_caches + KMALLOC_CACHES) > > ??? can this ever be so? for positive KMALLOC_CACHES, I mean... An allocated kmem_cache structure is definitely not in the range of the kmalloc_caches array. This is basically checking if s is pointing to the static kmalloc array. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org