From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id AFFD36B0044 for ; Tue, 15 Dec 2009 00:03:15 -0500 (EST) Received: from spaceape8.eur.corp.google.com (spaceape8.eur.corp.google.com [172.28.16.142]) by smtp-out.google.com with ESMTP id nBF53BIM000964 for ; Tue, 15 Dec 2009 05:03:11 GMT Received: from pxi29 (pxi29.prod.google.com [10.243.27.29]) by spaceape8.eur.corp.google.com with ESMTP id nBF538DD025746 for ; Mon, 14 Dec 2009 21:03:09 -0800 Received: by pxi29 with SMTP id 29so2669457pxi.1 for ; Mon, 14 Dec 2009 21:03:08 -0800 (PST) Date: Mon, 14 Dec 2009 21:03:07 -0800 (PST) From: David Rientjes Subject: Re: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v4.2 In-Reply-To: <20091215134319.CDD3.A69D9226@jp.fujitsu.com> Message-ID: References: <20091215103202.eacfd64e.kamezawa.hiroyu@jp.fujitsu.com> <20091215134319.CDD3.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: KAMEZAWA Hiroyuki , Andrew Morton , Daisuke Nishimura , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter List-ID: On Tue, 15 Dec 2009, KOSAKI Motohiro wrote: > To compare vsz is only meaningful when the same program are compared. > But oom killer don't. To compare vsz between another program DONT detect > any memory leak. > You're losing the ability to detect that memory leak because you'd be using a baseline that userspace cannot possibly know at the time of oom. You cannot possibly insist that users understand the amount of resident memory for all applications when tuning the heuristic adjuster from userspace. In other words, how do you plan on userspace being able to identify tasks that are memory leakers if you change the baseline to rss? Unless you have an answer to this question, you're not admitting the problem that the oom killer is primarily designed to address. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org