Re: [RFC,PATCH 2/2] dmapool: Honor GFP_* flags.

[Christoph Lameter <cl@linux-foundation.org>]

On Wed, 2 Dec 2009, Roger Oksanen wrote:

>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/mm/dmapool.c b/mm/dmapool.c
> index 2fdd7a1..e270f7f 100644
> --- a/mm/dmapool.c
> +++ b/mm/dmapool.c
> @@ -312,6 +312,8 @@
>  	void *retval;
>  	int tries = 0;
>  	const gfp_t can_wait = mem_flags & __GFP_WAIT;
> +	/* dma_pool_alloc uses its own wait logic */
> +	mem_flags &= ~__GFP_WAIT;

Why mask the wait flag? If you can call the page allocator with __GFP_WAIT
then you dont have to loop.

> -	page = pool_alloc_page(pool, GFP_ATOMIC | (can_wait && tries % 10
> +	page = pool_alloc_page(pool, mem_flags | (can_wait && tries % 10
>  						  ? __GFP_NOWARN : 0));

You are now uselessly calling the page allocator with __GFP_WAIT cleared
although the context allows you to wait.

Just pass through the mem_flags? Rename them gfp_flags for consistencies
sake?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>