From: Vincent Li <macli@brc.ubc.ca>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Vincent Li <macli@brc.ubc.ca>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/4] vmscan: make lru_index() helper function
Date: Thu, 26 Nov 2009 21:54:29 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.0911262153080.15015@kernalhack.brc.ubc.ca> (raw)
In-Reply-To: <20091127144636.A7E4.A69D9226@jp.fujitsu.com>
On Fri, 27 Nov 2009, KOSAKI Motohiro wrote:
> > > @@ -1373,10 +1378,8 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> > > */
> > > reclaim_stat->recent_rotated[file] += nr_rotated;
> > >
> > > - move_active_pages_to_lru(zone, &l_active,
> > > - LRU_ACTIVE + file * LRU_FILE);
> > > - move_active_pages_to_lru(zone, &l_inactive,
> > > - LRU_BASE + file * LRU_FILE);
> > > + move_active_pages_to_lru(zone, &l_active, lru_index(1, file));
> > > + move_active_pages_to_lru(zone, &l_inactive, lru_index(0, file));
> >
> > How about:
> > move_active_pages_to_lru(zone, &l_active, lru_index(LRU_ACTIVE, file));
> > move_active_pages_to_lru(zone, &l_inactive, lru_index(LRU_BASE, file));
> > ?
>
> No. lru_index mean convert two boolean to one index. it shoudn't be passed
> lru index itself.
Yeah, you are right, I immediately realized I am wrong after replying,
sorry.
Vincent
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-27 5:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 0:17 [PATCH 1/4] vmscan: more simplify shrink_inactive_list() KOSAKI Motohiro
2009-11-27 0:18 ` [PATCH 2/4] vmscan: make lru_index() helper function KOSAKI Motohiro
2009-11-27 5:44 ` Vincent Li
2009-11-27 5:47 ` KOSAKI Motohiro
2009-11-27 5:54 ` Vincent Li [this message]
2009-11-27 0:19 ` [PATCH 3/4] vmscan: move PGDEACTIVATE modification to shrink_active_list() KOSAKI Motohiro
2009-11-27 0:23 ` [RFC][PATCH 4/4] vmscan: vmscan don't use pcp list KOSAKI Motohiro
2009-11-27 16:17 ` Mel Gorman
2009-12-02 7:15 ` KOSAKI Motohiro
2009-12-02 14:25 ` Mel Gorman
2009-11-27 19:25 ` Christoph Lameter
2009-12-04 8:26 ` [PATCH 1/4] vmscan: more simplify shrink_inactive_list() KOSAKI Motohiro
2009-12-06 4:19 ` Wu Fengguang
2009-12-07 5:48 ` KOSAKI Motohiro
2009-12-06 5:41 ` [PATCH] vmscan: aligned scan batching Wu Fengguang
2009-12-07 6:17 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0911262153080.15015@kernalhack.brc.ubc.ca \
--to=macli@brc.ubc.ca \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox