linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Matt Mackall <mpm@selenic.com>,
	paulmck@linux.vnet.ibm.com, Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Nick Piggin <npiggin@suse.de>
Subject: Re: lockdep complaints in slab allocator
Date: Tue, 24 Nov 2009 13:22:08 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.0911241313220.12339@chino.kir.corp.google.com> (raw)
In-Reply-To: <1259097150.4531.1822.camel@laptop>

On Tue, 24 Nov 2009, Peter Zijlstra wrote:

> > slqb still has a 5-10% performance regression compared to slab for 
> > benchmarks such as netperf TCP_RR on machines with high cpu counts, 
> > forcing that type of regression isn't acceptable.
> 
> Having _4_ slab allocators is equally unacceptable.
> 

So you just advocated to merging slqb so that it gets more testing and 
development, and then use its inclusion in a statistic to say we should 
remove others solely because the space is too cluttered?

We use slab partially because the regression in slub was too severe for 
some of our benchmarks, and while CONFIG_SLUB may be the kernel default 
there are still distros that use slab as the default as well.  We cannot 
simply remove an allocator that is superior to others because it is old or 
has increased complexity.

I'd suggest looking at how widely used slob is and whether it has a 
significant advantage over slub.  We'd then have two allocators for 
specialized workloads (and slub is much better for diagnostics) and one in 
development.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-11-24 21:22 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 18:12 Paul E. McKenney
2009-11-20  6:49 ` Pekka Enberg
2009-11-20  9:25   ` Peter Zijlstra
2009-11-20 10:38     ` Pekka Enberg
2009-11-20 10:52       ` Peter Zijlstra
2009-11-20 11:05         ` Pekka Enberg
2009-11-20 14:48           ` Paul E. McKenney
2009-11-20 15:17             ` Peter Zijlstra
2009-11-20 16:25               ` Paul E. McKenney
2009-11-20 15:09           ` Peter Zijlstra
2009-11-23 19:00             ` Pekka Enberg
2009-11-23 19:10               ` Matt Mackall
2009-11-23 19:13                 ` Pekka Enberg
2009-11-24 16:33                   ` Peter Zijlstra
2009-11-24 17:00                     ` Paul E. McKenney
2009-11-24 17:12                       ` Matt Mackall
2009-11-24 17:58                         ` Paul E. McKenney
2009-11-24 18:14                         ` Peter Zijlstra
2009-11-24 18:25                           ` Paul E. McKenney
2009-11-24 18:31                             ` Peter Zijlstra
2009-11-24 18:53                               ` Christoph Lameter
2009-11-24 18:54                               ` Paul E. McKenney
2009-11-24 19:23                           ` Matt Mackall
2009-11-24 19:50                             ` Paul E. McKenney
2009-11-24 20:46                             ` Peter Zijlstra
2009-11-24 20:53                               ` Matt Mackall
2009-11-24 21:01                                 ` Peter Zijlstra
2009-11-24 21:03                                   ` David Rientjes
2009-11-24 21:12                                     ` Peter Zijlstra
2009-11-24 21:19                                       ` Pekka Enberg
2009-11-24 21:22                                       ` David Rientjes [this message]
2009-11-24 21:35                                         ` Peter Zijlstra
2009-11-24 21:46                                           ` David Rientjes
2009-11-24 22:23                                             ` Paul E. McKenney
2009-11-25  7:12                                               ` Pekka Enberg
2009-11-25  7:25                                           ` Pekka Enberg
2009-11-27 17:22                                             ` Christoph Lameter
2009-11-24 21:48                                       ` Paul E. McKenney
2009-11-24 21:16                                   ` Pekka Enberg
2009-11-24 21:07                             ` Pekka Enberg
2009-11-24 22:55                               ` Matt Mackall
2009-11-25 21:59                                 ` David Rientjes
2009-11-25 23:06                                   ` Matt Mackall
2009-11-27 17:28                                   ` Christoph Lameter
2009-11-30 23:14                                     ` David Rientjes
2009-12-01  0:21                                       ` Matt Mackall
2009-12-01 22:41                                         ` David Rientjes
2009-12-01 16:47                                       ` Christoph Lameter
2009-11-27 17:26                               ` Christoph Lameter
2009-11-23 19:30               ` Christoph Lameter
2009-11-23 19:43                 ` Paul E. McKenney
2009-11-23 19:50                 ` Pekka Enberg
2009-11-23 20:01                   ` Pekka Enberg
2009-11-23 20:57                     ` Paul E. McKenney
2009-11-23 21:01                     ` Matt Mackall
2009-11-24 16:23               ` Paul E. McKenney
2009-11-24 20:59                 ` Pekka Enberg
2009-11-24 21:26                   ` Peter Zijlstra
2009-11-25 10:42                     ` Pekka Enberg
2009-11-24 21:47                   ` Paul E. McKenney
2009-11-30 16:18                     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0911241313220.12339@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=npiggin@suse.de \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox