Re: [PATCH] [for mmotm-1113] mm: Simplify try_to_unmap_one()

[Vincent Li <macli@brc.ubc.ca>]

On Thu, 19 Nov 2009, KOSAKI Motohiro wrote:

> > 
> > Hi KOSAKI,
> > 
> > Thank you for the comment, I am still little confused with the last 
> > sentence.
> > 
> > On Thu, 19 Nov 2009, KOSAKI Motohiro wrote:
> > 
> > > 
> > > +
> > > +	/*
> > > +	 * We need mmap_sem locking, Otherwise VM_LOCKED check makes
> > > +	 * unstable result and race. Plus, We can't wait here because
> > > +	 * we now hold anon_vma->lock or mapping->i_mmap_lock.
> > > +	 * If trylock failed, The page remain evictable lru and
> > > +	 * retry to more unevictable lru by later vmscan.
> >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I am having 
> > trouble to undestand it. Yeah, I should read more code, but the sentence 
> > itself make me confused :).
> 
> Um, this is wrong.
> Probably, It should be
> 
> 	retry to move unevictable lru later.
> 
> Do you agree this?

Ah, let's see if I understand you correctly, if trylock failed, the page 
remain in evictable lru and later vmscan could retry to move the page to 
unevictable lru if the page is actually mlocked? 

Vincent

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>