From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 0FBC56B004D for ; Thu, 19 Nov 2009 00:27:47 -0500 (EST) Date: Wed, 18 Nov 2009 21:27:57 -0800 (PST) From: Vincent Li Subject: Re: [PATCH] [for mmotm-1113] mm: Simplify try_to_unmap_one() In-Reply-To: <20091119100525.3E2B.A69D9226@jp.fujitsu.com> Message-ID: References: <20091117173759.3DF6.A69D9226@jp.fujitsu.com> <20091118151803.35f55ca3.akpm@linux-foundation.org> <20091119100525.3E2B.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: linux-mm List-ID: Hi KOSAKI, Thank you for the comment, I am still little confused with the last sentence. On Thu, 19 Nov 2009, KOSAKI Motohiro wrote: > > + > + /* > + * We need mmap_sem locking, Otherwise VM_LOCKED check makes > + * unstable result and race. Plus, We can't wait here because > + * we now hold anon_vma->lock or mapping->i_mmap_lock. > + * If trylock failed, The page remain evictable lru and > + * retry to more unevictable lru by later vmscan. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I am having trouble to undestand it. Yeah, I should read more code, but the sentence itself make me confused :). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org