Re: [RESEND][PATCH V1] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value.

[Vincent Li <macli@brc.ubc.ca>]

On Thu, 3 Sep 2009, Andrew Morton wrote:

> On Fri, 4 Sep 2009 10:37:17 +0900 Minchan Kim <minchan.kim@gmail.com> wrote:
> 
> > On Fri, Sep 4, 2009 at 6:06 AM, Andrew Morton<akpm@linux-foundation.org> wrote:
> > > On Wed, __2 Sep 2009 16:49:25 -0700
> > > Vincent Li <macli@brc.ubc.ca> wrote:
> > >
> > >> If we can't isolate pages from LRU list, we don't have to account page movement, either.
> > >> Already, in commit 5343daceec, KOSAKI did it about shrink_inactive_list.
> > >>
> > >> This patch removes unnecessary overhead of page accounting
> > >> and locking in shrink_active_list as follow-up work of commit 5343daceec.
> > >>
> > >> Signed-off-by: Vincent Li <macli@brc.ubc.ca>
> > >> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
> > >> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > >> Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
> > >> Acked-by: Rik van Riel <riel@redhat.com>
> > >>
> > >> ---
> > >> __mm/vmscan.c | __ __9 +++++++--
> > >> __1 files changed, 7 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/mm/vmscan.c b/mm/vmscan.c
> > >> index 460a6f7..2d1c846 100644
> > >> --- a/mm/vmscan.c
> > >> +++ b/mm/vmscan.c
> > >> @@ -1319,9 +1319,12 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> > >> __ __ __ if (scanning_global_lru(sc)) {
> > >> __ __ __ __ __ __ __ zone->pages_scanned += pgscanned;
> 
> Someone's email client is replacing 0x09 with 0xa0, dammit.

I am using alpine 2.0, I got:

 [ Sending Preferences ]
      [X]  Do Not Send Flowed Text                                               
      [ ]  Downgrade Multipart to Text                                           
      [X]  Enable 8bit ESMTP Negotiation    (default)
      [ ]  Strip Whitespace Before Sending                                       
 
And Documentation/email-clients.txt have:

Config options:
- quell-flowed-text is needed for recent versions
- the "no-strip-whitespace-before-send" option is needed

Am I the one to blame? Should I uncheck the 'Do Not Send Flowed Text'? I 
am sorry if it is my fault.

Vincent

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>