From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id 8297B6B004D for ; Mon, 31 Aug 2009 20:02:18 -0400 (EDT) Date: Mon, 31 Aug 2009 17:01:03 -0700 (PDT) From: Vincent Li Subject: Re: [PATCH] mm/vsmcan: check shrink_active_list() sc->isolate_pages() return value. In-Reply-To: <20090901082926.61872690.minchan.kim@barrios-desktop> Message-ID: References: <1251759241-15167-1-git-send-email-macli@brc.ubc.ca> <20090901082926.61872690.minchan.kim@barrios-desktop> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: Vincent Li , linux-mm@kvack.org, KOSAKI Motohiro , Rik van Riel , Wu Fengguang , Andrew Morton List-ID: On Tue, 1 Sep 2009, Minchan Kim wrote: > On Mon, 31 Aug 2009 15:54:01 -0700 > Vincent Li wrote: > > > commit 5343daceec (If sc->isolate_pages() return 0...) make shrink_inactive_list handle > > sc->isolate_pages() return value properly. Add similar proper return value check for > > shrink_active_list() sc->isolate_pages(). > > > > Signed-off-by: Vincent Li > Reviewed-by: Minchan Kim > > You should have write down your patch's effect clearly > in changelog although it's easy. ;-) Yes, I should have. This patch is inspired by Kosaki's patch, I thought mentioning that commit would make this patch as follow-up work and changelog clear enough. Would following changelog ok? ---- Add proper return value check for shrink_active_list() sc->isolate_pages(). When "nr_taken == 0" 1: nr_scan related statistics should still be caculated. 2: jump to the end of function and release zone->lru_lock. ---- Regards, Vincent Li Biomedical Research Center University of British Columbia -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org