Re: [PATCH] mm/vmscan: change generic_file_write() comment to do_sync_write()

[Vincent Li <macli@brc.ubc.ca>]

On Wed, 26 Aug 2009, Christoph Hellwig wrote:

> On Tue, Aug 25, 2009 at 03:18:08PM -0700, Vincent Li wrote:
> > Commit 543ade1fc9 (Streamline generic_file_* interfaces and filemap cleanups)
> > removed generic_file_write() in filemap. For consistency, change the comment in
> > vmscan pageout() to do_sync_write().
> 
> I think the right replacement would be __generic_file_aio_write.  But

There is no __generic_file_aio_write, but __generic_file_aio_write_nolock, 
generic_file_aio_write and generic_file_aio_write_nolock. 

I read the commit 543ade1fc9, it seems it replaced all .write = generic_file_write to 
.write = do_sync_write. I thought they are the same.

> from a quick glance over the code don't have the slightest idea what it
> is referring to.

I read the code  over and over again, still no clue about the comment :-(. 

Vincent Li
Biomedical Research Center
University of British Columbia

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>