From: David Rientjes <rientjes@google.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [-mm patch] Show memcg information during OOM
Date: Mon, 2 Feb 2009 12:37:54 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.0902021235500.26971@chino.kir.corp.google.com> (raw)
In-Reply-To: <20090202141705.GE918@balbir.in.ibm.com>
On Mon, 2 Feb 2009, Balbir Singh wrote:
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 8e4be9c..954b0d5 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -813,6 +813,25 @@ bool mem_cgroup_oom_called(struct task_struct *task)
> rcu_read_unlock();
> return ret;
> }
> +
> +void mem_cgroup_print_mem_info(struct mem_cgroup *memcg)
> +{
> + if (!memcg)
> + return;
> +
> + printk(KERN_WARNING "Memory cgroups's name %s\n",
> + memcg->css.cgroup->dentry->d_name.name);
> + printk(KERN_WARNING "Cgroup memory: usage %llu, limit %llu"
> + " failcnt %llu\n", res_counter_read_u64(&memcg->res, RES_USAGE),
> + res_counter_read_u64(&memcg->res, RES_LIMIT),
> + res_counter_read_u64(&memcg->res, RES_FAILCNT));
> + printk(KERN_WARNING "Cgroup memory+swap: usage %llu, limit %llu "
> + "failcnt %llu\n",
> + res_counter_read_u64(&memcg->memsw, RES_USAGE),
> + res_counter_read_u64(&memcg->memsw, RES_LIMIT),
> + res_counter_read_u64(&memcg->memsw, RES_FAILCNT));
> +}
> +
> /*
> * Unlike exported interface, "oom" parameter is added. if oom==true,
> * oom-killer can be invoked.
I think you'd want a less critical log level for these messages such as
KERN_INFO.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-02 20:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 12:52 Balbir Singh
2009-02-02 12:59 ` KOSAKI Motohiro
2009-02-02 14:12 ` Balbir Singh
2009-02-02 14:17 ` Balbir Singh
2009-02-02 20:37 ` David Rientjes [this message]
2009-02-02 20:54 ` Balbir Singh
2009-02-02 21:05 ` David Rientjes
2009-02-03 4:41 ` Balbir Singh
2009-02-03 5:41 ` Balbir Singh
2009-02-03 5:45 ` David Rientjes
2009-02-02 13:45 ` Johannes Weiner
2009-02-03 3:44 ` Daisuke Nishimura
2009-02-03 5:55 ` Daisuke Nishimura
2009-02-03 6:04 ` David Rientjes
2009-02-02 14:08 ` Balbir Singh
2009-02-03 1:21 ` KAMEZAWA Hiroyuki
2009-02-03 4:34 ` Balbir Singh
2009-02-03 1:29 ` Li Zefan
2009-02-03 4:41 ` Balbir Singh
2009-02-03 4:47 ` David Rientjes
2009-02-03 4:55 ` Balbir Singh
2009-02-03 5:25 ` David Rientjes
2009-02-03 5:33 ` Balbir Singh
2009-02-03 5:24 ` Li Zefan
2009-02-03 5:35 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0902021235500.26971@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox