From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id BBEAD8D0039 for ; Thu, 3 Mar 2011 06:41:02 -0500 (EST) Date: Thu, 3 Mar 2011 13:37:37 +0200 (EET) From: Aaro Koskinen Subject: Re: [PATCH] procfs: fix /proc//maps heap check In-Reply-To: <20110303102631.B939.A69D9226@jp.fujitsu.com> Message-ID: References: <1298996813-8625-1-git-send-email-aaro.koskinen@nokia.com> <20110303102631.B939.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: Aaro Koskinen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, stable@kernel.org Hi, On Thu, 3 Mar 2011, KOSAKI Motohiro wrote: >> On Tue, 1 Mar 2011, Aaro Koskinen wrote: >>> The current check looks wrong and prints "[heap]" only if the mapping >>> matches exactly the heap. However, the heap may be merged with some >>> other mappings, and there may be also be multiple mappings. >>> >>> Signed-off-by: Aaro Koskinen >>> Cc: stable@kernel.org [...] > Your description said, > the heap may be merged with some other mappings, > ^^^^^^ > but your example is splitting case. not merge. In other words, your > patch care splitting case but break merge case. > > Ok, we have no obvious correct behavior. This is debatable. So, > Why do you think vma splitting case is important than merge? Sorry, I was unclear. The current behaviour is wrong for both merged and split cases, and I think the patch fixes both. And yes, the example program is for the split case. I'll see if I can make a test program for the merged case... A. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org