From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 4D9936B004D for ; Tue, 18 Aug 2009 13:56:21 -0400 (EDT) Received: from localhost (smtp.ultrahosting.com [127.0.0.1]) by smtp.ultrahosting.com (Postfix) with ESMTP id 0D08782C813 for ; Tue, 18 Aug 2009 13:56:39 -0400 (EDT) Received: from smtp.ultrahosting.com ([74.213.175.254]) by localhost (smtp.ultrahosting.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B43s2rqfF9ZV for ; Tue, 18 Aug 2009 13:56:34 -0400 (EDT) Received: from gentwo.org (unknown [74.213.171.31]) by smtp.ultrahosting.com (Postfix) with ESMTP id 6476082C651 for ; Tue, 18 Aug 2009 13:56:34 -0400 (EDT) Date: Tue, 18 Aug 2009 13:56:22 -0400 (EDT) From: Christoph Lameter Subject: Re: [PATCH 3/3] page-allocator: Move pcp static fields for high and batch off-pcp and onto the zone In-Reply-To: <20090818164216.GA13435@csn.ul.ie> Message-ID: References: <1250594162-17322-1-git-send-email-mel@csn.ul.ie> <1250594162-17322-4-git-send-email-mel@csn.ul.ie> <20090818164216.GA13435@csn.ul.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Linux Memory Management List , Nick Piggin , Linux Kernel Mailing List List-ID: On Tue, 18 Aug 2009, Mel Gorman wrote: > On Tue, Aug 18, 2009 at 10:18:48AM -0400, Christoph Lameter wrote: > > > > This will increase the cache footprint for the hot code path. Could these > > new variable be moved next to zone fields that are already in use there? > > The pageset array is used f.e. > > > > pageset is ____cacheline_aligned_in_smp so putting pcp->high/batch near > it won't help in terms of cache footprint. This is why I located it near > watermarks because it's known they'll be needed at roughly the same time > pcp->high/batch would be normally accessed. watermarks are not accessed from the hot code path in free_hot_cold page. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org