From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with SMTP id C066D6B006A for ; Mon, 20 Jul 2009 11:27:13 -0400 (EDT) Received: from localhost (smtp.ultrahosting.com [127.0.0.1]) by smtp.ultrahosting.com (Postfix) with ESMTP id 4559582C41F for ; Mon, 20 Jul 2009 11:46:59 -0400 (EDT) Received: from smtp.ultrahosting.com ([74.213.175.254]) by localhost (smtp.ultrahosting.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ohrswIIMsLxm for ; Mon, 20 Jul 2009 11:46:59 -0400 (EDT) Received: from gentwo.org (unknown [74.213.171.31]) by smtp.ultrahosting.com (Postfix) with ESMTP id 381FF82C437 for ; Mon, 20 Jul 2009 11:46:48 -0400 (EDT) Date: Mon, 20 Jul 2009 11:27:08 -0400 (EDT) From: Christoph Lameter Subject: Re: [PATCH 3/3] add isolate pages vmstat In-Reply-To: <20090720143838.7481.A69D9226@jp.fujitsu.com> Message-ID: References: <20090717085821.A900.A69D9226@jp.fujitsu.com> <20090720143838.7481.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Wu Fengguang , Rik van Riel , Minchan Kim List-ID: On Mon, 20 Jul 2009, KOSAKI Motohiro wrote: > > On Fri, 17 Jul 2009, KOSAKI Motohiro wrote: > > > > > > Why do a separate pass over all the migrates pages? Can you add the > > > > _inc_xx somewhere after the page was isolated from the lru by calling > > > > try_to_unmap()? > > > > > > calling try_to_unmap()? the pages are isolated before calling migrate_pages(). > > > migrate_pages() have multiple caller. then I put this __inc_xx into top of > > > migrate_pages(). > > > > Then put the inc_xxx's where the pages are isolated. > > Is there any benefit? Why do we need sprinkle __inc_xx to many place? Its only needed in one place where the pages are isolated. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org