From: Christoph Lameter <cl@linux-foundation.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"mel@csn.ul.ie" <mel@csn.ul.ie>,
"Zhao, Yakui" <yakui.zhao@intel.com>
Subject: Re: + memory-hotplug-update-zone-pcp-at-memory-online.patch added to -mm tree
Date: Tue, 30 Jun 2009 10:21:34 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0906301020420.6124@gentwo.org> (raw)
In-Reply-To: <20090630005828.GC21254@sli10-desk.sh.intel.com>
On Tue, 30 Jun 2009, Shaohua Li wrote:
> > foreach possible cpu?
> Just follows zone_pcp_init(), do you think we should change that too?
I plan to change that but for now this would be okay.
> > > + struct per_cpu_pageset *pset;
> > > + struct per_cpu_pages *pcp;
> > > +
> > > + pset = zone_pcp(zone, cpu);
> > > + pcp = &pset->pcp;
> > > +
> > > + local_irq_save(flags);
> > > + free_pages_bulk(zone, pcp->count, &pcp->list, 0);
> >
> > There are no pages in the pageset since the pcp batch is zero right?
> It might not be zero for a populated zone, see above comments.
But you are populating an unpopulated zone?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-30 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906291949.n5TJno8X028680@imap1.linux-foundation.org>
[not found] ` <alpine.DEB.1.10.0906291814150.21956@gentwo.org>
2009-06-30 0:58 ` Shaohua Li
2009-06-30 14:21 ` Christoph Lameter [this message]
2009-07-01 1:46 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0906301020420.6124@gentwo.org \
--to=cl@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=shaohua.li@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox