From: Christoph Lameter <cl@linux-foundation.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
penberg@cs.helsinki.fi, mpm@selenic.com, jdb@comx.dk
Subject: Re: [PATCH RFC] fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b
Date: Mon, 29 Jun 2009 18:30:12 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0906291827050.21956@gentwo.org> (raw)
In-Reply-To: <20090625193137.GA16861@linux.vnet.ibm.com>
On Thu, 25 Jun 2009, Paul E. McKenney wrote:
> Jesper noted that kmem_cache_destroy() invokes synchronize_rcu() rather
> than rcu_barrier() in the SLAB_DESTROY_BY_RCU case, which could result
> in RCU callbacks accessing a kmem_cache after it had been destroyed.
>
> The following untested (might not even compile) patch proposes a fix.
It could be seen to be the responsibility of the caller of
kmem_cache_destroy to insure that no accesses are pending.
If the caller specified destroy by rcu on cache creation then he also
needs to be aware of not destroying the cache itself until all rcu actions
are complete. This is similar to the caution that has to be execised then
accessing cache data itself.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-29 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 19:31 Paul E. McKenney
2009-06-25 21:27 ` Matt Mackall
2009-06-25 22:08 ` Paul E. McKenney
2009-06-26 8:45 ` Pekka Enberg
2009-06-26 9:03 ` Nick Piggin
2009-06-26 9:11 ` Pekka Enberg
2009-06-29 22:30 ` Christoph Lameter [this message]
2009-06-29 22:45 ` Matt Mackall
2009-06-29 23:19 ` Christoph Lameter
2009-06-30 0:06 ` Matt Mackall
2009-06-30 6:00 ` Paul E. McKenney
2009-06-30 6:58 ` Pekka Enberg
2009-06-30 14:20 ` Christoph Lameter
2009-06-30 14:26 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0906291827050.21956@gentwo.org \
--to=cl@linux-foundation.org \
--cc=jdb@comx.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox