From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 611FE6B005A for ; Wed, 3 Jun 2009 10:44:33 -0400 (EDT) Received: from makko.or.mcafeemobile.com by x35.xmailserver.org with [XMail 1.26 ESMTP Server] id for from ; Tue, 2 Jun 2009 12:57:46 -0400 Date: Tue, 2 Jun 2009 09:51:42 -0700 (PDT) From: Davide Libenzi Subject: Re: [PATCH 18/23] vfs: Teach epoll to use file_hotplug_lock In-Reply-To: <1243893048-17031-18-git-send-email-ebiederm@xmission.com> Message-ID: References: <1243893048-17031-18-git-send-email-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: "Eric W. Biederman" Cc: Al Viro , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Hugh Dickins , Tejun Heo , Alexey Dobriyan , Linus Torvalds , Alan Cox , Greg Kroah-Hartman , Nick Piggin , Andrew Morton , Christoph Hellwig , "Eric W. Biederman" , "Eric W. Biederman" List-ID: On Mon, 1 Jun 2009, Eric W. Biederman wrote: > From: Eric W. Biederman > > Signed-off-by: Eric W. Biederman > --- > fs/eventpoll.c | 39 ++++++++++++++++++++++++++++++++------- > 1 files changed, 32 insertions(+), 7 deletions(-) This patchset gives me the willies for the amount of changes and possible impact on many subsystems. Without having looked at the details, are you aware that epoll does not act like poll/select, and fds are not automatically removed (as in, dequeued from the poll wait queue) in any foreseeable amount of time after a POLLERR is received? As far as the usespace API goes, they have the right to remain there. - Davide -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org