From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 7AC056B00C7 for ; Tue, 24 Feb 2009 12:40:38 -0500 (EST) Received: from localhost (smtp.ultrahosting.com [127.0.0.1]) by smtp.ultrahosting.com (Postfix) with ESMTP id 3B04A82C443 for ; Tue, 24 Feb 2009 12:44:52 -0500 (EST) Received: from smtp.ultrahosting.com ([74.213.175.254]) by localhost (smtp.ultrahosting.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gQa3Ew+fzt3N for ; Tue, 24 Feb 2009 12:44:47 -0500 (EST) Received: from qirst.com (unknown [74.213.171.31]) by smtp.ultrahosting.com (Postfix) with ESMTP id 8FD1382C3D6 for ; Tue, 24 Feb 2009 12:44:47 -0500 (EST) Date: Tue, 24 Feb 2009 12:31:41 -0500 (EST) From: Christoph Lameter Subject: Re: [PATCH 10/19] Calculate the preferred zone for allocation only once In-Reply-To: <1235477835-14500-11-git-send-email-mel@csn.ul.ie> Message-ID: References: <1235477835-14500-1-git-send-email-mel@csn.ul.ie> <1235477835-14500-11-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra List-ID: On Tue, 24 Feb 2009, Mel Gorman wrote: > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6f26944..074f9a6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1399,24 +1399,19 @@ static void zlc_mark_zone_full(struct zonelist *zonelist, struct zoneref *z) > */ > static struct page * > get_page_from_freelist(gfp_t gfp_mask, nodemask_t *nodemask, unsigned int order, > - struct zonelist *zonelist, int high_zoneidx, int alloc_flags) > + struct zonelist *zonelist, int high_zoneidx, int alloc_flags, > + struct zone *preferred_zone) > { This gets into a quite a number of parameters now. Pass a structure like in vmscan.c? Or simplify things to be able to run get_page_from_freelist with less parameters? The number of parameters seem to be too high for a fastpath function. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org