From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
mathieu.desnoyers@polymtl.ca, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
mpm@selenic.com, tglx@linutronix.de
Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks.
Date: Mon, 11 Aug 2008 10:36:25 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0808111033320.29861@gandalf.stny.rr.com> (raw)
In-Reply-To: <48A04AEE.8090606@linux-foundation.org>
On Mon, 11 Aug 2008, Christoph Lameter wrote:
> Pekka Enberg wrote:
>
> > The function call is supposed to go away when we convert kmemtrace to
> > use Mathieu's markers but I suppose even then we have a problem with
> > inlining?
>
> The function calls are overwritten with NOPs? Or how does that work?
I believe in the latest version they are just a variable test. But when
Mathieu's immediate code makes it in (which it is in linux-tip), we will
be overwriting the conditionals with nops (Mathieu, correct me if I'm
wrong here).
But the calls themselves are done in the unlikely branch. This is
important, as Mathieu stated in previous thread. The reason is that all
the stack setup for the function call is also in the unlikely branch, and
the normal fast path does not take a hit for the function call setup.
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-08-11 14:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 17:14 [PATCH 0/5] kmemtrace Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 1/5] kmemtrace: Core implementation Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 2/5] kmemtrace: Additional documentation Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 3/5] kmemtrace: SLAB hooks Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-10 17:14 ` [PATCH 5/5] kmemtrace: SLOB hooks Eduard - Gabriel Munteanu
2008-08-10 17:48 ` Pekka Enberg
2008-08-10 23:18 ` Matt Mackall
2008-08-12 6:46 ` Pekka Enberg
2008-08-11 14:04 ` [PATCH 4/5] kmemtrace: SLUB hooks Christoph Lameter
2008-08-11 14:09 ` Pekka Enberg
2008-08-11 14:13 ` Christoph Lameter
2008-08-11 14:16 ` Pekka Enberg
2008-08-11 14:21 ` Christoph Lameter
2008-08-11 14:22 ` Pekka Enberg
2008-08-12 15:29 ` Eduard - Gabriel Munteanu
2008-08-12 15:43 ` Mathieu Desnoyers
2008-08-13 2:09 ` Matt Mackall
2008-08-11 14:36 ` Steven Rostedt [this message]
2008-08-11 18:28 ` Mathieu Desnoyers
2008-08-11 14:30 ` Steven Rostedt
2008-08-11 14:37 ` Christoph Lameter
2008-08-11 15:34 ` Frank Ch. Eigler
2008-08-11 15:48 ` Christoph Lameter
2008-08-11 15:54 ` Steven Rostedt
2008-08-11 15:57 ` Frank Ch. Eigler
2008-08-11 18:29 ` Mathieu Desnoyers
2008-08-12 15:25 ` Eduard - Gabriel Munteanu
2008-08-12 6:46 ` [PATCH 3/5] kmemtrace: SLAB hooks Pekka Enberg
2008-08-12 6:46 ` [PATCH 2/5] kmemtrace: Additional documentation Pekka Enberg
2008-08-18 19:57 ` Randy Dunlap
2008-08-12 6:46 ` [PATCH 1/5] kmemtrace: Core implementation Pekka Enberg
2008-08-19 17:43 [PATCH 1/5] Revert "kmemtrace: fix printk format warnings" Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 2/5] kmemtrace: Better alternative to " Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 3/5] SLUB: Replace __builtin_return_address(0) with _RET_IP_ Eduard - Gabriel Munteanu
2008-08-19 17:43 ` [PATCH 4/5] kmemtrace: SLUB hooks Eduard - Gabriel Munteanu
2008-08-19 19:10 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0808111033320.29861@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox