From: Hugh Dickins <hughd@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
Minchan Kim <minchan.kim@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first
Date: Thu, 20 May 2010 19:10:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.1.00.1005201859260.23122@tigran.mtv.corp.google.com> (raw)
In-Reply-To: <20100521103935.1E56.A69D9226@jp.fujitsu.com>
On Fri, 21 May 2010, KOSAKI Motohiro wrote:
>
> > Acked-by: Hugh Dickins <hughd@google.com>
> >
> > Thanks - though I don't quite agree with your description: I can't
> > see why the lru_cache_add_active_anon() was ever justified - that
> > "active" came in along with the separate anon and file LRU lists.
>
> If you have any worry, can you please share it? I'll test such workload
> and fix the issue if necessary. You are expert than me in this area.
?? I've acked the patch: my worry is only with the detail of your
comments on the history - in my view it was always wrong to put on
the active LRU there, and I'm glad that you have now fixed it.
If you really want to test some workload on 2.6.28 to see if it too
works better with your fix, I won't stop you - but I'd much prefer
you to be applying your mind to 2.6.35 and 2.6.36!
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-21 2:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 8:44 KOSAKI Motohiro
2010-05-19 18:47 ` Rik van Riel
2010-05-19 21:51 ` Johannes Weiner
2010-05-19 23:29 ` Minchan Kim
2010-05-20 1:00 ` Wu Fengguang
2010-05-21 0:36 ` KOSAKI Motohiro
2010-05-21 18:57 ` Andrew Morton
2010-05-22 0:04 ` KOSAKI Motohiro
2010-05-21 21:32 ` Andrew Morton
2010-05-21 1:31 ` Hugh Dickins
2010-05-21 1:43 ` KOSAKI Motohiro
2010-05-21 2:10 ` Hugh Dickins [this message]
2010-05-21 2:18 ` KOSAKI Motohiro
2010-05-21 16:25 ` Henrique de Moraes Holschuh
2010-05-21 2:00 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1005201859260.23122@tigran.mtv.corp.google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox