From: Steve VanDeBogart <vandebo-lkml@NerdBox.Net>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Chris Frost <frost@cs.ucla.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Steve Dickson <steved@redhat.com>,
David Howells <dhowells@redhat.com>,
Xu Chenfeng <xcf@ustc.edu.cn>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/readahead.c: update the LRU positions of in-core pages, too
Date: Wed, 27 Jan 2010 23:16:49 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.1.00.1001272300120.2909@abydos.NerdBox.Net> (raw)
In-Reply-To: <28c262361001262309x332a895aoa906dda0bc040859@mail.gmail.com>
On Wed, 27 Jan 2010, Minchan Kim wrote:
> This patch effect happens when inactive file list is small, I think.
> It means it's high memory pressure. so if we move ra pages into
This patch does the same thing regardless of memory pressure - it
doesn't just apply in high memory pressure situations. Is your concern
that in high memory pressure situations this patch with make things worse?
> head of inactive list, other application which require free page urgently
> suffer from latency or are killed.
I don't think this patch will affect the number of pages reclaimed, only
which pages are reclaimed. In extreme cases it could increase the time
needed to reclaim that many pages, but the inactive list would have to be
very short.
> If VM don't have this patch, of course ra pages are discarded and
> then I/O performance would be bad. but as I mentioned, it's time
> high memory pressure. so I/O performance low makes system
> natural throttling. It can help out of system memory pressure.
Even in low memory situations, improving I/O performance can help the
overall system performance. For example if most of the inactive list
is dirty, needlessly discarding pages, just to refetch them will clog
I/O and increase the time needed to write out the dirty pages.
> In summary I think it's good about viewpoint of I/O but I am not sure
> it's good about viewpoint of system.
In this case, I think what's good for I/O is good for the system.
Please help me understand if I am missing something. Thanks
--
Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-28 7:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 21:55 Chris Frost
2010-01-21 5:47 ` Wu Fengguang
2010-01-23 4:03 ` Chris Frost
2010-01-23 10:22 ` Wu Fengguang
2010-01-25 0:42 ` KAMEZAWA Hiroyuki
2010-01-25 2:45 ` Wu Fengguang
2010-01-25 22:36 ` Chris Frost
2010-01-26 13:02 ` Wu Fengguang
2010-01-26 13:32 ` Wu Fengguang
2010-01-31 14:31 ` Wu Fengguang
2010-02-01 2:06 ` Chris Frost
2010-02-01 2:17 ` Wu Fengguang
2010-02-02 0:15 ` Chris Frost
2010-01-27 7:09 ` Minchan Kim
2010-01-27 12:21 ` Wu Fengguang
2010-01-28 7:16 ` Steve VanDeBogart [this message]
2010-01-28 8:09 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.1001272300120.2909@abydos.NerdBox.Net \
--to=vandebo-lkml@nerdbox.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=frost@cs.ucla.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=steved@redhat.com \
--cc=xcf@ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox