Re: [PATCH 3/5] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit

[Vincent Li <macli@brc.ubc.ca>]

On Fri, 23 Oct 2009, Vincent Li wrote:

> > 
> > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> > ---
> >  mm/vmscan.c |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> > 
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 64e4388..cd68109 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -2016,6 +2016,15 @@ loop_again:
> >  					priority != DEF_PRIORITY)
> >  				continue;
> >  
> > +			/*
> > +			 * Exit quickly to restart if it has been indicated
>                            ^^^^^^^^^^^^^^^^^^^^^^^ meaning exit to 
> lable loop_again in balance_pgdat ?

I took a second look, it seems you are refering to restart: in 
__alloc_pages_slowpath in page_alloc.c

> 
> > +			 * that higher orders are required
> > +			 */
> > +			if (pgdat->kswapd_max_order > order) {
> > +				all_zones_ok = 1;
> > +				goto out;
> > +			}
> 
> If exit quickly to loop_again, shouldn't all_zones_ok be 0 instead of 1?

all_zones_ok should be 1. Sorry for the noise.

Vincent

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>