Re: [PATCH 7/12] hugetlb: add per node hstate attributes

[David Rientjes <rientjes@google.com>]

On Mon, 12 Oct 2009, Lee Schermerhorn wrote:

> > Hmm, does this really work for memory hot-remove?  If all memory is 
> > removed from a nid, does node_hstates[nid]->hstate_objs[] get updated 
> > appropriately?  I assume we'd never pass that particular kobj to 
> > kobj_to_node_hstate() anymore, but I'm wondering if the pointer would 
> > remain in the hstate_kobjs[] table.
> 
> Patch 11 is intended to address this.  The hotplug notifier, added by
> that patch, will call hugetlb_unregister_node() in the event all memory
> is removed from a node.  hugetlb_unregister_node() NULLs out the per
> node hstate_kobjs[] after freeing them.  This patch [7/12] handles node
> hot-plug--as opposed to memory hot-plug that transitions the node
> to/from the memoryless state.
> 

Ahh, I see it done in hugetlb_register_node(), thanks.

There's probably not much of a need to unregister the attributes if all 
memory is removed, anyway, subsequent allocation attempts on its node 
should simply fail.  It looks like your patches address node hotplug well, 
thanks for the clarification.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>